fix(trace-view): Link list of profiles to right thread #103850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to fetch the thread id for the span and link to that directly.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| tid, | ||
| } | ||
| : {}; | ||
| : {tid}; |
Contributor
There was a problem hiding this comment.
Bug: Missing eventId for EAP span profile links
The conditional logic for building the query object doesn't handle EAP span nodes explicitly. When the node is an EAP span (which is neither a transaction node nor a regular span node), it falls through to the else case at line 83, creating a query with only {tid}. This omits the eventId field that's needed for profile links. EAP span nodes have an event_id that should be included in the query, similar to how transaction nodes include their event_id.
Abdkhan14
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to fetch the thread id for the span and link to that directly.