fix(eventstream): Fix trace item inserts to EAP via Snuba HTTP backend #103857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia Snuba HTTP backend
github-actions
bot
added
the
Scope: Backend
thetruecpaul
approved these changes
Nov 21, 2025
Contributor
thetruecpaul
left a comment
thetruecpaul
left a comment
There was a problem hiding this comment.
Looks good — thanks for the fix!
shashjar
deleted the
fix-eap-trace-item-inserts-via-snuba-http-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #103566.
The previous logic did not correctly serialize the trace item when making a POST request to the "/tests/entities/eap_items/insert_bytes" endpoint. With this updated logic we should see successful EAP inserts (example below).
Querying via
docker exec -it snuba-clickhouse-1 clickhouse-client --query "SELECT item_id, project_id, organization_id, trace_id, item_type, timestamp FROM eap_items_1_local ORDER BY timestamp DESC LIMIT 5 FORMAT Pretty".Before ingesting new event:
After ingesting new event:
