✨ feat(gitlab): add inbound/outbound assignment & comment support#103877
✨ feat(gitlab): add inbound/outbound assignment & comment support#103877iamrajjoshi wants to merge 1 commit intomasterfrom
Conversation
| "on_resolve": pm.resolved_status, | ||
| } | ||
| config["sync_status_forward"] = sync_status_forward | ||
| return config |
There was a problem hiding this comment.
Bug: Missing null check in get_config_data method
The get_config_data method accesses self.org_integration.config and self.org_integration.id without checking if self.org_integration is None. The base class implementation in IntegrationInstallation includes a guard if not self.org_integration: return {} before accessing config. This could cause an AttributeError in edge cases where the org integration doesn't exist or hasn't been set.
There was a problem hiding this comment.
didn't need it for other implementations
bf4b938 to
a178552
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
e3d8201 to
b0e16aa
Compare
b0e16aa to
7d5916a
Compare
a178552 to
6f88618
Compare
This PR adds inbound/outbound assignment and comment synchronization support between Sentry and GitLab issues.
It is gated behind
organizations:integrations-gitlab-project-managementflag.Comment Syncing
gitlab-comments.mov
Outbound Assignment Sync
gitlab-outbound.mov
Inbound Assignment Sync
gitlab-inbound.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.