Skip to content

✨ feat(gitlab): add inbound/outbound assignment & comment support#103877

Closed
iamrajjoshi wants to merge 1 commit intomasterfrom
raj/gitlab-feat-par/assgn-comments
Closed

✨ feat(gitlab): add inbound/outbound assignment & comment support#103877
iamrajjoshi wants to merge 1 commit intomasterfrom
raj/gitlab-feat-par/assgn-comments

Conversation

@iamrajjoshi
Copy link
Collaborator

This PR adds inbound/outbound assignment and comment synchronization support between Sentry and GitLab issues.

It is gated behind organizations:integrations-gitlab-project-management flag.

Comment Syncing

gitlab-comments.mov

Outbound Assignment Sync

gitlab-outbound.mov

Inbound Assignment Sync

gitlab-inbound.mov

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@iamrajjoshi iamrajjoshi self-assigned this Nov 23, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners November 23, 2025 22:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 23, 2025
"on_resolve": pm.resolved_status,
}
config["sync_status_forward"] = sync_status_forward
return config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing null check in get_config_data method

The get_config_data method accesses self.org_integration.config and self.org_integration.id without checking if self.org_integration is None. The base class implementation in IntegrationInstallation includes a guard if not self.org_integration: return {} before accessing config. This could cause an AttributeError in edge cases where the org integration doesn't exist or hasn't been set.

Fix in Cursor Fix in Web

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't need it for other implementations

@codecov
Copy link

codecov bot commented Nov 23, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
29933 1 29932 244
View the top 1 failed test(s) by shortest run time
tests.sentry.integrations.api.endpoints.test_organization_integration_details.OrganizationIntegrationDetailsPostTest::test_update_config_error
Stack Traces | 1.62s run time
#x1B[1m#x1B[.../api/endpoints/test_organization_integration_details.py#x1B[0m:82: in test_update_config_error
    response = self.get_error_response(
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:649: in get_error_response
    assert_status_code(response, status_code)
#x1B[1m#x1B[.../sentry/testutils/asserts.py#x1B[0m:47: in assert_status_code
    assert minimum <= response.status_code < maximum, (
#x1B[1m#x1B[31mE   AssertionError: (200, b'')#x1B[0m
#x1B[1m#x1B[31mE   assert 400 <= 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 200 = <Response status_code=200>.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@getsantry
Copy link
Contributor

getsantry bot commented Dec 15, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 15, 2025
@iamrajjoshi iamrajjoshi removed the Stale label Dec 16, 2025
@iamrajjoshi iamrajjoshi requested a review from a team December 27, 2025 01:18
@iamrajjoshi iamrajjoshi force-pushed the raj/gitlab-feat-par/assgn-comments branch from a178552 to 6f88618 Compare December 27, 2025 01:32
@iamrajjoshi iamrajjoshi requested review from a team as code owners December 27, 2025 01:32
@iamrajjoshi iamrajjoshi requested a review from a team December 27, 2025 01:32
@iamrajjoshi iamrajjoshi requested review from a team as code owners December 27, 2025 01:32
@iamrajjoshi iamrajjoshi requested review from a team as code owners December 27, 2025 01:32
@iamrajjoshi iamrajjoshi changed the base branch from raj/ghe-feat-par to master December 27, 2025 01:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant