Skip to content

Conversation

@cvxluo
Copy link
Contributor

@cvxluo cvxluo commented Nov 24, 2025

Switch to using the getsentry endpoint rather than having to copy paste data.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 24, 2025
@cvxluo cvxluo marked this pull request as ready for review November 24, 2025 19:44
@cvxluo cvxluo requested a review from a team as a code owner November 24, 2025 19:44
@cvxluo cvxluo requested a review from a team November 24, 2025 19:44
setShowInput(true);
localStorage.removeItem(STORAGE_KEY);
};
const clusterData = useMemo(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why use useMemo() here instead of doing something like const clusterData = topIssuesResponse?.data ?? [];?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question — the answer in theory is to prevent a rerender in the case where we make another api request, but the data doesn't change. practically, it's because this is pretty experimental and the code quality is poor — the best case is just not redefining the variable at all, which i'll look at as a followup

Base automatically changed from cvxluo/add-summary-top-issues to master November 24, 2025 21:03
@cvxluo cvxluo force-pushed the cvxluo/use-top-issues-endpoint branch from 1046218 to b79f4c8 Compare November 24, 2025 21:59
@cvxluo cvxluo merged commit 71764ad into master Nov 24, 2025
48 checks passed
@cvxluo cvxluo deleted the cvxluo/use-top-issues-endpoint branch November 24, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants