-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(issues): use top issues endpoint #103899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| setShowInput(true); | ||
| localStorage.removeItem(STORAGE_KEY); | ||
| }; | ||
| const clusterData = useMemo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, why use useMemo() here instead of doing something like const clusterData = topIssuesResponse?.data ?? [];?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question — the answer in theory is to prevent a rerender in the case where we make another api request, but the data doesn't change. practically, it's because this is pretty experimental and the code quality is poor — the best case is just not redefining the variable at all, which i'll look at as a followup
1046218 to
b79f4c8
Compare
Switch to using the getsentry endpoint rather than having to copy paste data.