Skip to content

Conversation

@Ahmed-Labs
Copy link
Member

@Ahmed-Labs Ahmed-Labs commented Nov 24, 2025

  • Adds the dataset name to the menu title when selecting filter tags.
  • Fixes spacing issues in filterSelector and addFilter menu titles.
  • Truncates filter key and value in the global filter selector (using middle ellipsis truncation).

Note: An easy way to test truncation is to add a spans global filter for span.description or sentry.normalized_description

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 24, 2025
@Ahmed-Labs Ahmed-Labs marked this pull request as ready for review November 25, 2025 21:28
@Ahmed-Labs Ahmed-Labs requested a review from a team as a code owner November 25, 2025 21:28
Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like a good chunk of comments but i promise it's nothing crazy lol

@Ahmed-Labs Ahmed-Labs enabled auto-merge (squash) November 26, 2025 16:55
@Ahmed-Labs Ahmed-Labs merged commit b556326 into master Nov 26, 2025
49 checks passed
@Ahmed-Labs Ahmed-Labs deleted the ahmed/chore/address-global-filter-ui-feedback branch November 26, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants