Skip to content

chore(replay): Cleanup zendesk feedback target in replay details #103908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

chore(replay): Cleanup zendesk feedback target in replay details #103908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions static/app/components/replays/header/feedbackButton.tsx
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions static/app/types/hooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ type DisabledMemberTooltipProps = {children: React.ReactNode};

type DashboardHeadersProps = {organization: Organization};

type ReplayFeedbackButton = {children: React.ReactNode};
type ReplayListPageHeaderProps = {children?: React.ReactNode};
type ReplayOnboardingAlertProps = {children: React.ReactNode};
type ReplayOnboardingCTAProps = {children: React.ReactNode; organization: Organization};
Expand Down Expand Up @@ -207,7 +206,6 @@ type ComponentHooks = {
'component:product-selection-availability': () => React.ComponentType<ProductSelectionAvailabilityProps>;
'component:product-unavailable-cta': () => React.ComponentType<ProductUnavailableCTAProps>;
'component:profiling-billing-banner': () => React.ComponentType<ProfilingBetaAlertBannerProps>;
'component:replay-feedback-button': () => React.ComponentType<ReplayFeedbackButton>;
'component:replay-list-page-header': () => React.ComponentType<ReplayListPageHeaderProps> | null;
'component:replay-onboarding-alert': () => React.ComponentType<ReplayOnboardingAlertProps>;
'component:replay-onboarding-cta': () => React.ComponentType<ReplayOnboardingCTAProps>;
Expand Down
3 changes: 1 addition & 2 deletions static/app/views/replays/detail/header/replayDetailsHeaderActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import FeedbackButton from 'sentry/components/feedbackButton/feedbackButton';
import * as Layout from 'sentry/components/layouts/thirds';
import Placeholder from 'sentry/components/placeholder';
import ConfigureReplayCard from 'sentry/components/replays/header/configureReplayCard';
import ReplayFeedbackButton from 'sentry/components/replays/header/feedbackButton';
import ReplayLoadingState from 'sentry/components/replays/player/replayLoadingState';
import {space} from 'sentry/styles/space';
import type useLoadReplayReader from 'sentry/utils/replays/hooks/useLoadReplayReader';
Expand Down Expand Up @@ -37,7 +36,7 @@ export default function ReplayDetailsHeaderActions({readerResult}: Props) {
>
{({replay}) => (
<ButtonActionsWrapper>
{replay.isVideoReplay() ? <FeedbackButton /> : <ReplayFeedbackButton />}
<FeedbackButton />
<ConfigureReplayCard
isMobile={replay.isVideoReplay()}
replayRecord={replay.getReplay()}
Expand Down
29 changes: 0 additions & 29 deletions static/gsApp/components/replayZendeskFeedback.tsx
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions static/gsApp/registerHooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ import PowerFeatureHovercard from 'getsentry/components/powerFeatureHovercard';
import {ProductSelectionAvailability} from 'getsentry/components/productSelectionAvailability';
import {ProductUnavailableCTA} from 'getsentry/components/productUnavailableCTA';
import ReplayOnboardingCTA from 'getsentry/components/replayOnboardingCTA';
import ReplayZendeskFeedback from 'getsentry/components/replayZendeskFeedback';
import SuperuserWarning, {
shouldExcludeOrg,
} from 'getsentry/components/superuser/superuserWarning';
Expand Down Expand Up @@ -222,7 +221,6 @@ const GETSENTRY_HOOKS: Partial<Hooks> = {
'component:first-party-integration-alert': () => FirstPartyIntegrationAlertHook,
'component:first-party-integration-additional-cta': () =>
FirstPartyIntegrationAdditionalCTA,
'component:replay-feedback-button': () => ReplayZendeskFeedback,
'component:replay-onboarding-alert': () => ReplayOnboardingAlert,
'component:replay-onboarding-cta': () => ReplayOnboardingCTA,
'component:replay-settings-alert': () => ReplaySettingsAlert,
Expand Down
Loading