Skip to content

fix(mcp): Use mutable search in mcp link generation #103911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

fix(mcp): Use mutable search in mcp link generation #103911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions static/app/views/insights/pages/mcp/components/mcpOverviewTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
} from 'sentry/components/tables/gridEditable';
import {t} from 'sentry/locale';
import {trackAnalytics} from 'sentry/utils/analytics';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import useOrganization from 'sentry/utils/useOrganization';
import usePageFilters from 'sentry/utils/usePageFilters';
import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';
Expand Down Expand Up @@ -111,19 +112,26 @@ export function McpOverviewTable() {
promptName={dataRow[SpanFields.MCP_PROMPT_NAME]}
/>
);
case 'failure_rate()':
case 'failure_rate()': {
const search = new MutableSearch(query);
search.addFilterValue(SpanFields.SPAN_STATUS, 'internal_error');
search.addFilterValue(
SpanFields.SPAN_DESCRIPTION,
dataRow[SpanFields.SPAN_DESCRIPTION]
);
return (
<ErrorRateCell
errorRate={dataRow['failure_rate()']}
total={dataRow['count()']}
issuesLink={getExploreUrl({
query: `${query} span.status:internal_error ${SpanFields.SPAN_DESCRIPTION}:${dataRow[SpanFields.SPAN_DESCRIPTION]}`,
query: search.formatString(),
selection,
organization,
referrer: MCPReferrer.MCP_OVERVIEW_TABLE,
})}
/>
);
}
case 'count()':
return <NumberCell value={dataRow['count()']} />;
case AVG_DURATION:
Expand Down Expand Up @@ -178,6 +186,9 @@ function SpanDescriptionCell({
fields.push('span.duration');
fields.push('timestamp');

const search = new MutableSearch('');
search.addFilterValue(SpanFields.SPAN_OP, 'mcp.server');
search.addFilterValue(SpanFields.SPAN_DESCRIPTION, spanDescription);
const link = getExploreUrl({
organization,
selection,
Expand All @@ -188,7 +199,7 @@ function SpanDescriptionCell({
yAxes: ['count(span.duration)'],
},
],
query: `span.op:mcp.server ${SpanFields.SPAN_DESCRIPTION}:"${spanDescription}"`,
query: search.formatString(),
sort: `-count(span.duration)`,
field: fields,
});
Expand Down
18 changes: 15 additions & 3 deletions static/app/views/insights/pages/mcp/components/mcpPromptsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
} from 'sentry/components/tables/gridEditable';
import {t} from 'sentry/locale';
import {trackAnalytics} from 'sentry/utils/analytics';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import useOrganization from 'sentry/utils/useOrganization';
import usePageFilters from 'sentry/utils/usePageFilters';
import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';
Expand Down Expand Up @@ -99,19 +100,26 @@ export function McpPromptsTable() {
switch (column.key) {
case SpanFields.MCP_PROMPT_NAME:
return <McpPromptCell prompt={dataRow[SpanFields.MCP_PROMPT_NAME]} />;
case 'failure_rate()':
case 'failure_rate()': {
const search = new MutableSearch(query);
search.addFilterValue(SpanFields.SPAN_STATUS, 'internal_error');
search.addFilterValue(
SpanFields.MCP_PROMPT_NAME,
dataRow[SpanFields.MCP_PROMPT_NAME]
);
return (
<ErrorRateCell
errorRate={dataRow['failure_rate()']}
total={dataRow['count()']}
issuesLink={getExploreUrl({
query: `${query} span.status:internal_error ${SpanFields.MCP_PROMPT_NAME}:${dataRow[SpanFields.MCP_PROMPT_NAME]}`,
query: search.formatString(),
selection,
organization,
referrer: MCPReferrer.MCP_PROMPT_TABLE,
})}
/>
);
}
case 'count()':
return <NumberCell value={dataRow['count()']} />;
case AVG_DURATION:
Expand Down Expand Up @@ -145,6 +153,10 @@ function McpPromptCell({prompt}: {prompt: string}) {
const organization = useOrganization();
const {selection} = usePageFilters();

const search = new MutableSearch('');
search.addFilterValue(SpanFields.SPAN_OP, 'mcp.server');
search.addFilterValue(SpanFields.MCP_PROMPT_NAME, prompt);

const link = getExploreUrl({
organization,
selection,
Expand All @@ -162,7 +174,7 @@ function McpPromptCell({prompt}: {prompt: string}) {
'span.duration',
'timestamp',
],
query: `span.op:mcp.server ${SpanFields.MCP_PROMPT_NAME}:"${prompt}"`,
query: search.formatString(),
sort: `-count(span.duration)`,
});
return <Link to={link}>{prompt}</Link>;
Expand Down
18 changes: 15 additions & 3 deletions static/app/views/insights/pages/mcp/components/mcpResourcesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
} from 'sentry/components/tables/gridEditable';
import {t} from 'sentry/locale';
import {trackAnalytics} from 'sentry/utils/analytics';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import useOrganization from 'sentry/utils/useOrganization';
import usePageFilters from 'sentry/utils/usePageFilters';
import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';
Expand Down Expand Up @@ -99,19 +100,26 @@ export function McpResourcesTable() {
switch (column.key) {
case SpanFields.MCP_RESOURCE_URI:
return <McpResourceCell resource={dataRow[SpanFields.MCP_RESOURCE_URI]} />;
case 'failure_rate()':
case 'failure_rate()': {
const search = new MutableSearch(query);
search.addFilterValue(SpanFields.SPAN_STATUS, 'internal_error');
search.addFilterValue(
SpanFields.MCP_RESOURCE_URI,
dataRow[SpanFields.MCP_RESOURCE_URI]
);
return (
<ErrorRateCell
errorRate={dataRow['failure_rate()']}
total={dataRow['count()']}
issuesLink={getExploreUrl({
query: `${query} span.status:internal_error ${SpanFields.MCP_RESOURCE_URI}:${dataRow[SpanFields.MCP_RESOURCE_URI]}`,
query: search.formatString(),
selection,
organization,
referrer: MCPReferrer.MCP_RESOURCE_TABLE,
})}
/>
);
}
case 'count()':
return <NumberCell value={dataRow['count()']} />;
case AVG_DURATION:
Expand Down Expand Up @@ -145,6 +153,10 @@ function McpResourceCell({resource}: {resource: string}) {
const organization = useOrganization();
const {selection} = usePageFilters();

const search = new MutableSearch('');
search.addFilterValue(SpanFields.SPAN_OP, 'mcp.server');
search.addFilterValue(SpanFields.MCP_RESOURCE_URI, resource);

const link = getExploreUrl({
organization,
selection,
Expand All @@ -156,7 +168,7 @@ function McpResourceCell({resource}: {resource: string}) {
},
],
field: ['span.description', 'span.status', 'span.duration', 'timestamp'],
query: `span.op:mcp.server ${SpanFields.MCP_RESOURCE_URI}:"${resource}"`,
query: search.formatString(),
sort: `-count(span.duration)`,
});
return <Link to={link}>{resource}</Link>;
Expand Down
18 changes: 15 additions & 3 deletions static/app/views/insights/pages/mcp/components/mcpToolsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
} from 'sentry/components/tables/gridEditable';
import {t} from 'sentry/locale';
import {trackAnalytics} from 'sentry/utils/analytics';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import useOrganization from 'sentry/utils/useOrganization';
import usePageFilters from 'sentry/utils/usePageFilters';
import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';
Expand Down Expand Up @@ -99,19 +100,26 @@ export function McpToolsTable() {
switch (column.key) {
case SpanFields.MCP_TOOL_NAME:
return <McpToolCell tool={dataRow[SpanFields.MCP_TOOL_NAME]} />;
case 'failure_rate()':
case 'failure_rate()': {
const search = new MutableSearch(query);
search.addFilterValue(SpanFields.SPAN_STATUS, 'internal_error');
search.addFilterValue(
SpanFields.MCP_TOOL_NAME,
dataRow[SpanFields.MCP_TOOL_NAME]
);
return (
<ErrorRateCell
errorRate={dataRow['failure_rate()']}
total={dataRow['count()']}
issuesLink={getExploreUrl({
query: `${query} span.status:internal_error ${SpanFields.MCP_TOOL_NAME}:${dataRow[SpanFields.MCP_TOOL_NAME]}`,
query: search.formatString(),
selection,
organization,
referrer: MCPReferrer.MCP_TOOL_TABLE,
})}
/>
);
}
case 'count()':
return <NumberCell value={dataRow['count()']} />;
case AVG_DURATION:
Expand Down Expand Up @@ -145,6 +153,10 @@ function McpToolCell({tool}: {tool: string}) {
const organization = useOrganization();
const {selection} = usePageFilters();

const search = new MutableSearch('');
search.addFilterValue(SpanFields.SPAN_OP, 'mcp.server');
search.addFilterValue(SpanFields.MCP_TOOL_NAME, tool);

const link = getExploreUrl({
organization,
selection,
Expand All @@ -155,7 +167,7 @@ function McpToolCell({tool}: {tool: string}) {
yAxes: ['count(span.duration)'],
},
],
query: `span.op:mcp.server ${SpanFields.MCP_TOOL_NAME}:"${tool}"`,
query: search.formatString(),
sort: `-count(span.duration)`,
field: ['span.description', 'mcp.tool.result.content', 'span.duration', 'timestamp'],
});
Expand Down
Loading