fix(profiling): Link event id for profiles in trace view #103921
Conversation
This ensures that we link with the appropriate event id in the trace view and do not show the transaction in the flamechart view if there's no transaction present.
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| return {eventId: TraceTree.ParentTransaction(node)?.value?.event_id}; | ||
| } | ||
| if (isEAPSpanNode(node)) { | ||
| const threadId = node.value.additional_attributes?.['thread.id'] ?? undefined; | ||
| return { | ||
| eventId: node.value.transaction_id, | ||
| tid: typeof threadId === 'string' ? threadId : undefined, | ||
| }; | ||
| } | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
Bug: getProfileRouteQueryFromNode can return undefined eventId, leading to ?eventId=undefined in URL for regular profiles due to missing dropUndefinedKeys.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The getProfileRouteQueryFromNode function can return {eventId: undefined} for regular span nodes or an empty object for unknown node types. When a regular profile is associated with a span node, this {eventId: undefined} is passed to generateProfileFlamechartRouteWithQuery(), which does not use dropUndefinedKeys. This results in a URL parameter like ?eventId=undefined, creating an invalid query parameter instead of omitting it, breaking the intent of not showing the transaction if no transaction is present.
💡 Suggested Fix
Modify generateProfileFlamechartRouteWithQuery to use dropUndefinedKeys on its query object, similar to generateContinuousProfileFlamechartRouteWithQuery, to prevent undefined eventId values from being included in the URL.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
static/app/views/performance/newTraceDetails/traceDrawer/tabs/traceProfiles.tsx#L147-L162
Potential issue: The `getProfileRouteQueryFromNode` function can return `{eventId:
undefined}` for regular span nodes or an empty object for unknown node types. When a
regular profile is associated with a span node, this `{eventId: undefined}` is passed to
`generateProfileFlamechartRouteWithQuery()`, which does not use `dropUndefinedKeys`.
This results in a URL parameter like `?eventId=undefined`, creating an invalid query
parameter instead of omitting it, breaking the intent of not showing the transaction if
no transaction is present.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3294777
roaga
left a comment
roaga
left a comment
There was a problem hiding this comment.
don't know this code but makes sense to me
This ensures that we link with the appropriate event id in the trace view and do not show the transaction in the flamechart view if there's no transaction present.