Skip to content

ref(events): Singularize pluralized params in the events endpoint #103923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
+9 −9
Merged

ref(events): Singularize pluralized params in the events endpoint #103923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/sentry/api/endpoints/organization_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,9 @@ def paginator_factory(scoped_dataset):
dashboard_widget_id = request.GET.get("dashboardWidgetId", None)
discover_saved_query_id = request.GET.get("discoverSavedQueryId", None)
additional_queries = AdditionalQueries(
span=request.GET.getlist("spanQueries"),
log=request.GET.getlist("logQueries"),
metric=request.GET.getlist("metricQueries"),
span=request.GET.getlist("spanQuery"),
log=request.GET.getlist("logQuery"),
metric=request.GET.getlist("metricQuery"),
)

def get_rpc_config():
Expand Down
12 changes: 6 additions & 6 deletions tests/snuba/api/endpoints/test_organization_events_cross_trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def test_cross_trace_query_with_logs(self) -> None:
"orderby": "count()",
"project": self.project.id,
"dataset": "spans",
"logQueries": ["message:foo"],
"logQuery": ["message:foo"],
}
)

Expand Down Expand Up @@ -102,7 +102,7 @@ def test_cross_trace_query_with_spans(self) -> None:
"orderby": "count()",
"project": self.project.id,
"dataset": "spans",
"spanQueries": ["tags[foo]:six"],
"spanQuery": ["tags[foo]:six"],
}
)

Expand Down Expand Up @@ -167,8 +167,8 @@ def test_cross_trace_query_with_spans_and_logs(self) -> None:
"orderby": "count()",
"project": self.project.id,
"dataset": "spans",
"spanQueries": ["tags[foo]:six"],
"logQueries": ["message:foo"],
"spanQuery": ["tags[foo]:six"],
"logQuery": ["message:foo"],
}
)

Expand Down Expand Up @@ -230,7 +230,7 @@ def test_cross_trace_query_with_multiple_spans(self) -> None:
"orderby": "count()",
"project": self.project.id,
"dataset": "spans",
"spanQueries": ["tags[foo]:six", "tags[foo]:seven"],
"spanQuery": ["tags[foo]:six", "tags[foo]:seven"],
}
)

Expand Down Expand Up @@ -288,7 +288,7 @@ def test_cross_trace_qurey_with_multiple_logs(self) -> None:
"orderby": "count()",
"project": self.project.id,
"dataset": "spans",
"logQueries": ["message:faa", "message:foo"],
"logQuery": ["message:faa", "message:foo"],
}
)

Expand Down
Loading