feat(explore): Add hooks for date page filter props based on data cat… #103931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egory This replaces the custom functions we wrote for each data category with a hook that accepts a list of data categories so we can automatically determine what the expected date page filter props should be. This sets it up so that we can replace the hook with an alternate implementation in order to support the coming retention changes.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| return a; | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: Lost defaultPeriod when mixing data categories
The max function only returns one of the two MaxPickableDaysOptions objects without merging their properties. When combining data categories where some specify defaultPeriod (like TRACE_METRICS, LOG_BYTE, LOG_ITEM) with others that don't (like SPANS), the defaultPeriod gets lost. This causes the date filter to use an incorrect default period when multiple data categories are mixed.
k-fish
approved these changes
Nov 25, 2025
Zylphrex
deleted the
txiao/feat/add-hooks-for-date-page-filter-props-based-on-data-category-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…egory
This replaces the custom functions we wrote for each data category with a hook that accepts a list of data categories so we can automatically determine what the expected date page filter props should be. This sets it up so that we can replace the hook with an alternate implementation in order to support the coming retention changes.
Same as #103822 but fixed typing issues in 17c69c7