feat(grouping): Add options to control grouphash caching #103943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mrduncan
approved these changes
Nov 25, 2025
cvxluo
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new options,
grouping.use_ingest_grouphash_caching,grouping.ingest_grouphash_existence_cache_expiry, andgrouping.ingest_grouphash_object_cache_expiry, to control the caching of both a check on secondary grouphash existence and of actualGroupHashobjects during ingest. The two expiry times are controlled separately because caching a boolean takes less memory than caching a whole Django ORM object (albeit a quite simple one), so we can probably let things stay in the first cache longer than the second. (We'll know after we turn caching on and see what the respective hit rates are.)