feat(deletions): Retry timed out tasks #103966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduled deletions can take a long time, we should retry the task if we time out. Fixes [SENTRY-41GE](https://sentry.sentry.io/issues/6683627821/).
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103966 +/- ##
========================================
Coverage 80.61% 80.62%
========================================
Files 9311 9311
Lines 397320 397332 +12
Branches 25338 25338
========================================
+ Hits 320297 320342 +45
+ Misses 76582 76549 -33
Partials 441 441 |
markstory
previously approved these changes
Nov 25, 2025
markstory
dismissed
their stale review
there is a change that needs to be made first.
Co-authored-by: Mark Story <mark@mark-story.com>
roggenkemper
approved these changes
Nov 25, 2025
armenzg
deleted the
11_25/retry_long_running_task/scheduled_deletions/armenzg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduled deletions can take a long time, we should retry the task if we time out.
I know that it will be retried on the next reattempt deletions schedule but I want to make a lot more progress during the two hours window (5 re-attempts for 20 minutes each run).
Fixes SENTRY-41GE.