tests(deletions): Add CustomTaskQueue to enable testing #103974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
armenzg
commented
Nov 25, 2025
| # Configure within each Process | ||
| import logging | ||
|
|
||
| from sentry.utils.imports import import_string |
Member
Author
There was a problem hiding this comment.
Some of the logic from the multiprocess_worker function is moved into a new function called task_execution.
This allows testing the deletion without being impacted by the multiprocessing set up (DB changes by the tests are not seen by the processes).
| ) | ||
|
|
||
| for chunk in q.iterator(chunk_size=100): | ||
| for chunk in q.iterator(chunk_size=DELETES_BY_PROJECT_CHUNK_SIZE): |
Member
Author
There was a problem hiding this comment.
This will allow patching within the test.
|
|
||
| with ( | ||
| assume_test_silo_mode(SiloMode.REGION), | ||
| patch("sentry.runner.commands.cleanup.DELETES_BY_PROJECT_CHUNK_SIZE", 2), |
Member
Author
There was a problem hiding this comment.
Two groups at a time will be processed.
| def test_run_bulk_query_deletes_by_project(self) -> None: | ||
| """Test that the function runs bulk query deletes by project as expected.""" | ||
| days = 30 | ||
| self.create_group() |
Member
Author
There was a problem hiding this comment.
The only group that won't be past retention.
The changes includes allow replacing the task_queue with a custom class to support testing of cleanup functions.
armenzg
force-pushed
the
11_25/run_by_project_changes/armenzg
branch
from
4613654 to
b0a31a6
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
yuvmen
approved these changes
Nov 25, 2025
Member
yuvmen
left a comment
yuvmen
left a comment
There was a problem hiding this comment.
nice! just handle the few bot comments I think they could be right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes includes allow replacing the task_queue with a custom class to support testing of cleanup functions.