Skip to content

fix(preprod): fix positioning of app size tooltip #103978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

fix(preprod): fix positioning of app size tooltip #103978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
913fee8
fix(preprod): fix positioning of app size tooltip
trevor-e Nov 25, 2025
4bf85dd
Merge branch 'master' into telkins/watch-label-ui
trevor-e Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 32 additions & 40 deletions static/app/views/preprod/buildDetails/main/buildDetailsMetricCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,41 +128,32 @@ export function BuildDetailsMetricCards(props: BuildDetailsMetricCardsProps) {

return (
<Flex gap="lg" wrap="wrap">
{metricsCards.map(card => {
const valueContent = (
{metricsCards.map(card => (
<MetricCard
key={card.key}
icon={card.icon}
label={card.title}
labelTooltip={card.labelTooltip}
action={
card.showInsightsButton
? {
icon: <IconSettings size="sm" color="white" />,
tooltip: t('View insight details'),
ariaLabel: t('View insight details'),
onClick: () => {
trackAnalytics('preprod.builds.details.open_insights_sidebar', {
organization,
platform: platformProp ?? null,
project_type: projectType,
source: 'metric_card',
});
onOpenInsightsSidebar();
},
}
: undefined
}
>
<Heading as="h3">
<MetricValue $interactive={Boolean(card.watchBreakdown)}>
{card.value}
</MetricValue>
{card.percentageText ?? ''}
</Heading>
);

return (
<MetricCard
key={card.key}
icon={card.icon}
label={card.title}
labelTooltip={card.labelTooltip}
action={
card.showInsightsButton
? {
icon: <IconSettings size="sm" color="white" />,
tooltip: t('View insight details'),
ariaLabel: t('View insight details'),
onClick: () => {
trackAnalytics('preprod.builds.details.open_insights_sidebar', {
organization,
platform: platformProp ?? null,
project_type: projectType,
source: 'metric_card',
});
onOpenInsightsSidebar();
},
}
: undefined
}
>
{card.watchBreakdown ? (
<Tooltip
title={
Expand All @@ -171,16 +162,17 @@ export function BuildDetailsMetricCards(props: BuildDetailsMetricCardsProps) {
watchValue={card.watchBreakdown.watchValue}
/>
}
position="left"
position="bottom"
>
{valueContent}
<MetricValue $interactive>{card.value}</MetricValue>
</Tooltip>
) : (
valueContent
<MetricValue>{card.value}</MetricValue>
)}
</MetricCard>
);
})}
{card.percentageText ?? ''}
</Heading>
</MetricCard>
))}
</Flex>
);
}
Expand Down
Loading