Skip to content

ref(ui): Use type-fest type for flatten #103998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
+7 −23
Merged

ref(ui): Use type-fest type for flatten #103998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions static/app/utils/types/flatten.tsx
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions static/app/views/insights/common/components/tableCells/starredSegmentCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import type {Simplify} from 'type-fest';

import {Button} from 'sentry/components/core/button';
import {IconStar} from 'sentry/icons';
import {t} from 'sentry/locale';
import type {EventsMetaType} from 'sentry/utils/discover/eventView';
import {FlexContainer} from 'sentry/utils/discover/styles';
import {useQueryClient} from 'sentry/utils/queryClient';
import type {Flatten} from 'sentry/utils/types/flatten';
import useProjects from 'sentry/utils/useProjects';
import {useStarredSegment} from 'sentry/views/insights/common/utils/useStarredSegment';
import type {SpanResponse} from 'sentry/views/insights/types';
Expand All @@ -15,7 +16,7 @@ interface Props {
segmentName: string;
}

type TableRow = Flatten<
type TableRow = Simplify<
Partial<SpanResponse> & Pick<SpanResponse, 'is_starred_transaction' | 'transaction'>
>;

Expand Down
7 changes: 4 additions & 3 deletions static/app/views/insights/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type {Simplify} from 'type-fest';

import type {PlatformKey} from 'sentry/types/project';
import type {MutableSearch} from 'sentry/utils/tokenizeSearch';
import type {Flatten} from 'sentry/utils/types/flatten';
import type {SupportedDatabaseSystem} from 'sentry/views/insights/database/utils/constants';

export enum ModuleName {
Expand Down Expand Up @@ -499,7 +500,7 @@ type SpanResponseRaw = {
[Property in SpanFields as `${SpanFunction.COUNT_IF}(${Property},${string},${string})`]: number;
};

export type SpanResponse = Flatten<SpanResponseRaw>;
export type SpanResponse = Simplify<SpanResponseRaw>;
export type SpanProperty = keyof SpanResponse;

export type SpanQueryFilters = Partial<Record<SpanStringFields, string>> & {
Expand Down Expand Up @@ -536,7 +537,7 @@ type ErrorResponseRaw = {
[Property in NoArgErrorFunction as `${Property}()`]: number;
};

export type ErrorResponse = Flatten<ErrorResponseRaw>;
export type ErrorResponse = Simplify<ErrorResponseRaw>;
export type ErrorProperty = keyof ErrorResponse;

// Maps the subregion code to the subregion name according to UN m49 standard
Expand Down
Loading