Skip to content

feat(eap): Support reading boolean attributes from response #104063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2025
Merged

feat(eap): Support reading boolean attributes from response #104063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98f856a
feat(eap): Support reading boolean attributes from response
phacops Nov 26, 2025
70a9cc7
Priorities
phacops Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/sentry/snuba/spans_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from sentry_protos.snuba.v1.request_common_pb2 import PageToken, TraceItemType

from sentry.exceptions import InvalidSearchQuery
from sentry.search.eap.constants import DOUBLE, INT, STRING, SUPPORTED_STATS_TYPES
from sentry.search.eap.constants import BOOLEAN, DOUBLE, INT, STRING, SUPPORTED_STATS_TYPES
from sentry.search.eap.resolver import SearchResolver
from sentry.search.eap.sampling import events_meta_from_rpc_request_meta
from sentry.search.eap.spans.definitions import SPAN_DEFINITIONS
Expand Down Expand Up @@ -241,7 +241,12 @@ def run_trace_query(
elif resolved_column.proto_definition.type == DOUBLE:
span[resolved_column.public_alias] = attribute.value.val_double
elif resolved_column.search_type == "boolean":
span[resolved_column.public_alias] = attribute.value.val_int == 1
span[resolved_column.public_alias] = (
attribute.value.val_bool or attribute.value.val_int == 1
)
elif resolved_column.proto_definition.type == BOOLEAN:
span[resolved_column.public_alias] = attribute.value.val_bool

elif resolved_column.proto_definition.type == INT:
span[resolved_column.public_alias] = attribute.value.val_int
if resolved_column.public_alias == "project.id":
Expand Down
Loading