feat(anomaly): add seer anomaly thresholds to metric monitor graph #104074
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| const additionalSeries = useMemo(() => { | ||
| const baseSeries = [...thresholdAdditionalSeries]; | ||
| const baseSeries = [...thresholdAdditionalSeries, ...anomalyThresholdSeries]; |
There was a problem hiding this comment.
Bug: Y-axis bounds don't account for anomaly threshold values
The maxValue calculation only considers series and thresholdMaxValue, but doesn't include values from the new anomalyThresholdSeries (specifically yhat_upper, yhat_lower, and value). The existing useMetricDetectorThresholdSeries hook returns a maxValue to ensure thresholds are visible, but useMetricDetectorAnomalyThresholds only returns the series without a max value. When the Y-axis max is explicitly set at line 306, anomaly threshold lines that exceed this bound will be clipped and not visible to users.
Additional Locations (1)
|
|
||
| const upperBoundData: Array<[number, number]> = []; | ||
| const lowerBoundData: Array<[number, number]> = []; | ||
| const seerValueData: Array<[number, number]> = []; |
There was a problem hiding this comment.
are we including the seer value just for debugging with plans to remove it later?
There was a problem hiding this comment.
yep! there are some things that seem out of sync so im including it for now for debugging(this is why I changed the feature flag to be email only)
Add Seer anomaly thresholds to metric monitor graph.
Red lines are upper and lower thresholds, yellow line is the historical value that seer has
Feature flag:
organizations:anomaly-detection-threshold-data(only enabled for me right now, if you want to see the changes add your email)