Skip to content

Conversation

@markstory
Copy link
Member

Using two different keys for organization snowflakeids results in duplicate sequence values when both are used. We end up using both as organizations created by Factories.create_organization() use the key from Organization while organizations created via the API endpoint use the module level key. Having the same key allows monolith mode deployments (and tests) that use a shared redis to not generate overlapping sequence values.

Refs #103967

Using two different keys for organization snowflakeids results in
duplicate sequence values when both are used. We end up using both as
organizations created by `Factories.create_organization()` use the key
from `Organization` while organizations created via the API endpoint use
the module level key. Having the same key allows monolith mode
deployments (and tests) that use a shared redis to not generate
overlapping sequence values.

Refs #103967
@markstory markstory requested a review from a team as a code owner November 26, 2025 21:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 26, 2025
This was more disruptive than I would have liked.
@markstory markstory merged commit 4ffe3dd into master Nov 27, 2025
66 checks passed
@markstory markstory deleted the chore-flake-org-snowflakeid branch November 27, 2025 15:42
markstory added a commit that referenced this pull request Nov 27, 2025
Redo of the changes in #103967 along with a removal of the skip
introduced in #104057. With the keys used for snowflakes aligned
(as of #104075) we shouldn't have flaky results anymore.

Refs INFRENG-210
markstory added a commit that referenced this pull request Dec 1, 2025
Redo of the changes in #103967 along with a removal of the skip
introduced in #104057. With the keys used for snowflakes aligned (as of
#104075) we shouldn't have flaky results anymore.

Refs INFRENG-210
jerryzhou196 pushed a commit that referenced this pull request Dec 1, 2025
Redo of the changes in #103967 along with a removal of the skip
introduced in #104057. With the keys used for snowflakes aligned (as of
#104075) we shouldn't have flaky results anymore.

Refs INFRENG-210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants