fix(aci): fix sending test notification for sentry app #104086
Merged
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104086 +/- ##
===========================================
+ Coverage 79.79% 80.63% +0.83%
===========================================
Files 9317 9319 +2
Lines 397569 397873 +304
Branches 25389 25389
===========================================
+ Hits 317242 320818 +3576
+ Misses 79875 76603 -3272
Partials 452 452 |
ceorourke
reviewed
Dec 1, 2025
cathteng
commented
Dec 1, 2025
ceorourke
approved these changes
Dec 1, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "label": None, | ||
| "value": [ | ||
| {"id": "1dedabd2-059d-457b-ac17-df39031d4593", "type": "team"} | ||
| ], # should stringify this |
Contributor
There was a problem hiding this comment.
Bug: Development comment left in test code
The inline comment # should stringify this at the end of line 399 is a development note that was not meant to be included in the final code. According to the PR discussion, this comment was identified by a reviewer and confirmed by the author that it "should be deleted."
jerryzhou196
pushed a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SentryAppFormConfigDataBlobexpectssetting["value"]to be a string. When data comes in from the existing Rule endpoints this may not be the case so we need tojson.dumplists if they come in.We already save json.dumped lists to the
Actiontable.Fixes SENTRY-5BB2