Skip to content

feature(explore-attr-breakdowns): Removing yAxis heuristic from selection hint #104087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2025
Merged

feature(explore-attr-breakdowns): Removing yAxis heuristic from selection hint #104087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b9b9e
feature(explore-attr-breakdowns): Removing yAxis heuristic from selec…
Nov 27, 2025
d7ef919
feature(explore-attr-breakdowns): Removing yAxis heuristic from selec…
Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 15 additions & 28 deletions static/app/views/explore/components/attributeBreakdowns/cohortComparisonContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {useQueryParamState} from 'sentry/utils/url/useQueryParamState';
import {useDebouncedValue} from 'sentry/utils/useDebouncedValue';
import useAttributeBreakdownComparison from 'sentry/views/explore/hooks/useAttributeBreakdownComparison';
import {useQueryParamsVisualizes} from 'sentry/views/explore/queryParams/context';
import {prettifyAggregation} from 'sentry/views/explore/utils';

import {Chart} from './cohortComparisonChart';
import {AttributeBreakdownsComponent} from './styles';
Expand All @@ -29,7 +28,6 @@ type SortingMethod = 'rrr';

const CHARTS_COLUMN_COUNT = 3;
const CHARTS_PER_PAGE = CHARTS_COLUMN_COUNT * 4;
const PERCENTILE_FUNCTION_PREFIXES = ['p50', 'p75', 'p90', 'p95', 'p99', 'avg'];

export function CohortComparison({
selection,
Expand Down Expand Up @@ -90,7 +88,7 @@ export function CohortComparison({
setPage(0);
}, [filteredRankedAttributes]);

const selectionHint = useMemo(() => {
const selectedRangeToDates = useMemo(() => {
if (!selection) {
return null;
}
Expand All @@ -102,31 +100,14 @@ export function CohortComparison({
startTimestamp = Math.min(startTimestamp, endTimestamp - 60_000);

const userTimezone = getUserTimezone() || moment.tz.guess();
const startDate = moment
.tz(startTimestamp, userTimezone)
.format('MMM D YYYY h:mm A z');
const endDate = moment.tz(endTimestamp, userTimezone).format('MMM D YYYY h:mm A z');

// Check if yAxis is a percentile function (only these functions should include "and is greater than or equal to")
const yAxisLower = yAxis.toLowerCase();
const isPercentileFunction = PERCENTILE_FUNCTION_PREFIXES.some(prefix =>
yAxisLower.startsWith(prefix)
);

const formattedFunction = prettifyAggregation(yAxis) ?? yAxis;
const start = moment.tz(startTimestamp, userTimezone).format('MMM D YYYY h:mm A z');
const end = moment.tz(endTimestamp, userTimezone).format('MMM D YYYY h:mm A z');

return {
selection: isPercentileFunction
? t(
`Selection is data between %s - %s and is greater than or equal to %s`,
startDate,
endDate,
formattedFunction
)
: t(`Selection is data between %s - %s`, startDate, endDate),
baseline: t('Baseline is all other spans from your query'),
start,
end,
};
}, [selection, yAxis]);
}, [selection]);

if (isError) {
return <LoadingError message={t('Failed to load attribute breakdowns')} />;
Expand All @@ -150,12 +131,18 @@ export function CohortComparison({
<AttributeBreakdownsComponent.LoadingCharts />
) : (
<Fragment>
{selectionHint && (
{selectedRangeToDates && (
<SelectionHintContainer>
<SelectionHint color={theme.chart.getColorPalette(0)?.[0]}>
{selectionHint.selection}
{t(
'Selection is data between %s - %s',
selectedRangeToDates.start,
selectedRangeToDates.end
)}
</SelectionHint>
<SelectionHint color="#A29FAA">
{t('Baseline is all other spans from your query')}
</SelectionHint>
<SelectionHint color="#A29FAA">{selectionHint.baseline}</SelectionHint>
</SelectionHintContainer>
)}
{filteredRankedAttributes.length > 0 ? (
Expand Down
Loading