Skip to content

typing(tests): Minor changes #104105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2025
Merged

typing(tests): Minor changes #104105

merged 3 commits into from
Nov 28, 2025

Conversation

@armenzg
Copy link
Member

@armenzg armenzg commented Nov 27, 2025 •
edited
Loading

If running mypy locally, we get these errors, however, the CI runs with PYTHONWARNINGS=error::RuntimeWarning mypy, thus, it won't complain about these.

@armenzg
typing(tests): Minor changes
1fdc856 
mypy locally is complaining about these.
@armenzg
Minor change
aaad43d
@armenzg armenzg self-assigned this Nov 27, 2025
@armenzg
Copy link
Member Author

armenzg commented Nov 27, 2025

bugbot review

@armenzg
Copy link
Member Author

armenzg commented Nov 27, 2025

@sentry review

cursor[bot]
cursor bot reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

@armenzg armenzg marked this pull request as ready for review November 27, 2025 19:57
@armenzg armenzg requested review from a team as code owners November 27, 2025 19:57
@armenzg armenzg merged commit a547c4f into master Nov 28, 2025
64 checks passed
@armenzg armenzg deleted the 11_27/tests_typing/armenzg branch November 28, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees

@armenzg armenzg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armenzg @Zylphrex