Skip to content

fix(explore): Bandaid to escape brackets #104108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2025
Merged

fix(explore): Bandaid to escape brackets #104108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a8607b
:adhesive_bandage: Add in temp fix to resolve issue for users
nsdeschenes Nov 27, 2025
3c8e88b
:necktie: Escape double quotes
nsdeschenes Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions static/app/views/explore/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type {PageFilters} from 'sentry/types/core';
import type {Tag, TagCollection} from 'sentry/types/group';
import type {Confidence, Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {defined} from 'sentry/utils';
import {defined, escapeDoubleQuotes} from 'sentry/utils';
import {encodeSort} from 'sentry/utils/discover/eventView';
import type {Sort} from 'sentry/utils/discover/fields';
import {
Expand Down Expand Up @@ -289,7 +289,13 @@ export function generateTargetQuery({
} else if (groupBy === 'environment' && typeof value === 'string') {
location.query.environment = value;
} else if (typeof value === 'string') {
search.setFilterValues(groupBy, [value]);
// TODO(nsdeschenes): Remove this once we have a proper way to handle quoted values
// that have square brackets included in the value
if (value.startsWith('[') && value.endsWith(']')) {
search.setFilterValues(groupBy, [`"${escapeDoubleQuotes(value)}"`]);
} else {
search.setFilterValues(groupBy, [value]);
}
}
}

Expand Down
Loading