Icon SlashForward Replacing Chevron in Breadcrumbs #104120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
TkDodo
approved these changes
Nov 28, 2025
roaga
pushed a commit
that referenced
this pull request
Dec 2, 2025
## Problem Both in the Replay Details and Span Waterfall, we have this ability to paginate to sibling events. However, the implementations are inconsistent. ### Replay Details <img width="2880" height="2042" alt="CleanShot 2025-11-28 at 14 04 39@2x" src="https://github.com/user-attachments/assets/ff6a81ce-dda5-4db6-b775-a3183a957eaf" /> ### Span Waterfall <img width="2880" height="2042" alt="CleanShot 2025-11-28 at 14 06 48@2x" src="https://github.com/user-attachments/assets/5fda7778-712d-4dfe-aa9b-e2c6a4f5fe2b" /> ## Goal This PR isn't about implementing the pagination UI consistently; rather, it's about modifying the breadcrumbs UI so that we can reach that end goal. Specifically, this PR swaps out the chevron icon for a forward slash (new icon). ### Before <img width="2352" height="277" alt="CleanShot 2025-11-28 at 13 58 09@2x" src="https://github.com/user-attachments/assets/8e4c6638-7785-4060-b0a4-1ba978589989" /> ### After <img width="2351" height="278" alt="CleanShot 2025-11-28 at 13 58 37@2x" src="https://github.com/user-attachments/assets/9ada7a5f-13a9-48dd-824e-e6fdb2fc01a1" /> ## Solution We're making this change because we want to reach an end goal where we have this ### Ideal end state <img width="1978" height="284" alt="CleanShot 2025-11-28 at 14 26 50@2x" src="https://github.com/user-attachments/assets/b3026ca0-3b8d-4898-bf76-933cf74e80b6" /> ### End state without this change <img width="1976" height="286" alt="CleanShot 2025-11-28 at 14 27 33@2x" src="https://github.com/user-attachments/assets/02d49a61-cae7-4db2-85ce-eb77cfedafbf" /> ## Solution Explanation In the realm of computing, the slash is frequently used to indicate a file path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Both in the Replay Details and Span Waterfall, we have this ability to paginate to sibling events. However, the implementations are inconsistent.
Replay Details
Span Waterfall
Goal
This PR isn't about implementing the pagination UI consistently; rather, it's about modifying the breadcrumbs UI so that we can reach that end goal. Specifically, this PR swaps out the chevron icon for a forward slash (new icon).
Before
After
Solution
We're making this change because we want to reach an end goal where we have this
Ideal end state
End state without this change
Solution Explanation
In the realm of computing, the slash is frequently used to indicate a file path.