Skip to content

feat(explore-attr-breakdowns): Removing hovering CTA #104144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2025
Merged

feat(explore-attr-breakdowns): Removing hovering CTA #104144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
319002e
feat(explore-attr-breakdowns): Removing hovering CTA
Nov 27, 2025
d6fef79
feat(explore-attr-breakdowns): Adding new alert
Nov 27, 2025
2ac87c0
feat(explore-attr-breakdowns): Resolving conflicts
Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 0 additions & 132 deletions static/app/views/explore/components/attributeBreakdowns/attributeComparisonCTA.tsx
View file
Open in desktop

This file was deleted.

139 changes: 76 additions & 63 deletions static/app/views/explore/components/attributeBreakdowns/attributeDistributionContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import styled from '@emotion/styled';
import {Button} from '@sentry/scraps/button/button';
import {ButtonBar} from '@sentry/scraps/button/buttonBar';
import {Flex} from '@sentry/scraps/layout';
import {Text} from '@sentry/scraps/text/text';

import {Alert} from 'sentry/components/core/alert';
import Panel from 'sentry/components/panels/panel';
import BaseSearchBar from 'sentry/components/searchBar';
import {IconChevron} from 'sentry/icons/iconChevron';
Expand Down Expand Up @@ -142,75 +144,86 @@ export function AttributeDistribution() {

return (
<Panel>
<Flex direction="column" gap="2xl" padding="xl">
<Fragment>
<ControlsContainer>
<StyledBaseSearchBar
placeholder={t('Search keys')}
onChange={q => {
setSearchQuery(q);
}}
query={debouncedSearchQuery}
size="sm"
/>
<AttributeBreakdownsComponent.FeedbackButton />
</ControlsContainer>
{isAttributeBreakdownsLoading || isCohortCountLoading ? (
<AttributeBreakdownsComponent.LoadingCharts />
) : error ? (
<AttributeBreakdownsComponent.ErrorState error={error} />
) : filteredAttributeDistribution.length > 0 ? (
<Fragment>
<ChartsGrid>
{filteredAttributeDistribution
.slice(page * CHARTS_PER_PAGE, (page + 1) * CHARTS_PER_PAGE)
.map(attribute => (
<Chart
key={attribute.name}
attributeDistribution={attribute}
cohortCount={cohortCount}
theme={theme}
/>
))}
</ChartsGrid>
<PaginationContainer>
<ButtonBar merged gap="0">
<Button
icon={<IconChevron direction="left" />}
aria-label={t('Previous')}
size="sm"
disabled={page === 0}
onClick={() => {
setPage(page - 1);
}}
<Flex direction="column" gap="xl" padding="xl">
<ChartSelectionAlert />
<ControlsContainer>
<StyledBaseSearchBar
placeholder={t('Search keys')}
onChange={q => {
setSearchQuery(q);
}}
query={debouncedSearchQuery}
size="sm"
/>
<AttributeBreakdownsComponent.FeedbackButton />
</ControlsContainer>
{isAttributeBreakdownsLoading || isCohortCountLoading ? (
<AttributeBreakdownsComponent.LoadingCharts />
) : error ? (
<AttributeBreakdownsComponent.ErrorState error={error} />
) : filteredAttributeDistribution.length > 0 ? (
<Fragment>
<ChartsGrid>
{filteredAttributeDistribution
.slice(page * CHARTS_PER_PAGE, (page + 1) * CHARTS_PER_PAGE)
.map(attribute => (
<Chart
key={attribute.name}
attributeDistribution={attribute}
cohortCount={cohortCount}
theme={theme}
/>
<Button
icon={<IconChevron direction="right" />}
aria-label={t('Next')}
size="sm"
disabled={
page ===
Math.ceil(
(filteredAttributeDistribution?.length ?? 0) / CHARTS_PER_PAGE
) -
1
}
onClick={() => {
setPage(page + 1);
}}
/>
</ButtonBar>
</PaginationContainer>
</Fragment>
) : (
<AttributeBreakdownsComponent.EmptySearchState />
)}
</Fragment>
))}
</ChartsGrid>
<PaginationContainer>
<ButtonBar merged gap="0">
<Button
icon={<IconChevron direction="left" />}
aria-label={t('Previous')}
size="sm"
disabled={page === 0}
onClick={() => {
setPage(page - 1);
}}
/>
<Button
icon={<IconChevron direction="right" />}
aria-label={t('Next')}
size="sm"
disabled={
page ===
Math.ceil(
(filteredAttributeDistribution?.length ?? 0) / CHARTS_PER_PAGE
) -
1
}
onClick={() => {
setPage(page + 1);
}}
/>
</ButtonBar>
</PaginationContainer>
</Fragment>
) : (
<AttributeBreakdownsComponent.EmptySearchState />
)}
</Flex>
</Panel>
);
}

function ChartSelectionAlert() {
return (
<Alert type="info">
<Text>
{t(
'Drag to select a region in the chart above and see how its breakdowns differ from the baseline.'
)}
</Text>
</Alert>
);
}

const ControlsContainer = styled('div')`
display: flex;
gap: ${space(0.5)};
Expand Down
Loading
Loading