Skip to content

ref(explorer): rm unnecessary manual limit #104184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

ref(explorer): rm unnecessary manual limit #104184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d87b4e5
ref(explorer): rm unnecessary manual limit
aliu39 Dec 1, 2025
b8c16af
rm comment
aliu39 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/sentry/seer/explorer/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,8 +1173,6 @@ def get_log_attributes_for_trace(
)

if not message_substring:
if limit is not None:
items = items[:limit] # Re-apply in case the endpoint didn't respect it.
return {"data": items}

# Filter on message substring.
Expand Down Expand Up @@ -1250,8 +1248,6 @@ def get_metric_attributes_for_trace(
)

if not metric_name:
if limit is not None:
items = items[:limit] # Re-apply in case the endpoint didn't respect it.
return {"data": items}

# Filter on metric name (exact case-insensitive match).
Expand Down
Loading