Skip to content

fix(preprod): Handle missing date_built in UI and backend (EME-671) #104444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Dec 8, 2025
+11 −3
Merged

fix(preprod): Handle missing date_built in UI and backend (EME-671) #104444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/sentry/preprod/api/endpoints/project_preprod_artifact_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def validate_preprod_artifact_update_schema(
"is_code_signature_valid": {"type": "boolean"},
"code_signature_errors": {"type": "array", "items": {"type": "string"}},
"missing_dsym_binaries": {"type": "array", "items": {"type": "string"}},
"build_date": {"type": "string"},
},
},
"android_app_info": {
Expand Down Expand Up @@ -90,6 +91,7 @@ def validate_preprod_artifact_update_schema(
"apple_app_info.is_code_signature_valid": "The is_code_signature_valid field must be a boolean.",
"apple_app_info.code_signature_errors": "The code_signature_errors field must be an array of strings.",
"apple_app_info.missing_dsym_binaries": "The missing_dsym_binaries field must be an array of strings.",
"apple_app_info.build_date": "The build_date field must be a string.",
"android_app_info": "The android_app_info field must be an object.",
"android_app_info.has_proguard_mapping": "The has_proguard_mapping field must be a boolean.",
"dequeued_at": "The dequeued_at field must be a string.",
Expand Down Expand Up @@ -293,6 +295,10 @@ def put(
if isinstance(binaries, list):
extras_updates["has_missing_dsym_binaries"] = len(binaries) > 0

if "build_date" in apple_info:
head_artifact.date_built = apple_info["build_date"]
updated_fields.append("date_built")

for field in [
"is_simulator",
"codesigning_type",
Expand Down
8 changes: 5 additions & 3 deletions static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarAppInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,17 @@ export function BuildDetailsSidebarAppInfo(props: BuildDetailsSidebarAppInfoProp
</Flex>
</Tooltip>
)}
{props.appInfo.date_added && (
<Tooltip title={t('App upload time')}>
{(props.appInfo.date_built || props.appInfo.date_added) && (
<Tooltip
title={props.appInfo.date_built ? t('App build time') : t('App upload time')}
>
<Flex gap="2xs" align="center">
<InfoIcon>
<IconClock />
</InfoIcon>
<Text>
{getFormattedDate(
getUtcToSystem(props.appInfo.date_added),
getUtcToSystem(props.appInfo.date_built || props.appInfo.date_added),
datetimeFormat,
{local: true}
)}
Expand Down
Loading