Skip to content

ref(explorer): support start/end in nav links #104490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliu39 merged 3 commits into from
Dec 6, 2025
Merged

ref(explorer): support start/end in nav links #104490

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9907cd
ref(explorer): support start/end in nav links
aliu39 Dec 5, 2025
0a68d66
review
aliu39 Dec 6, 2025
4f5f090
Change project parameter from '-1' to null
aliu39 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 33 additions & 86 deletions static/app/views/seerExplorer/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,97 +403,65 @@ export function buildToolLinkUrl(
): LocationDescriptor | null {
switch (toolLink.kind) {
case 'telemetry_live_search': {
const {dataset, query, stats_period, project_slugs, sort} = toolLink.params;

if (dataset === 'issues') {
// Build URL for issues search
const queryParams: Record<string, any> = {
query: query || '',
};

// If project_slugs is provided, look up the project IDs
if (project_slugs && project_slugs.length > 0 && projects) {
const projectIds = project_slugs
.map((slug: string) => projects.find(p => p.slug === slug)?.id)
.filter((id: string | undefined) => id !== undefined);
if (projectIds.length > 0) {
queryParams.project = projectIds;
}
}
const {dataset, project_slugs, query, sort, stats_period, start, end} =
toolLink.params;

if (stats_period) {
queryParams.statsPeriod = stats_period;
}
const queryParams: Record<string, any> = {
query: query || '',
project: null,
};
if (stats_period) {
queryParams.statsPeriod = stats_period;
}
if (sort) {
queryParams.sort = sort;
}
if (start) {
queryParams.start = start;
}
if (end) {
queryParams.end = end;
}

if (sort) {
queryParams.sort = sort;
// If project_slugs is provided, look up the IDs and include them in qparams
if (project_slugs && project_slugs.length > 0 && projects) {
const projectIds = project_slugs
.map((slug: string) => projects.find(p => p.slug === slug)?.id)
.filter((id: string | undefined) => id !== undefined);
if (projectIds.length > 0) {
queryParams.project = projectIds;
}
}

if (dataset === 'issues') {
return {
pathname: `/organizations/${orgSlug}/issues/`,
query: queryParams,
};
}

if (dataset === 'errors') {
const queryParams: Record<string, any> = {
dataset: 'errors',
queryDataset: 'error-events',
query: query || '',
project: null,
};

if (stats_period) {
queryParams.statsPeriod = stats_period;
}

// If project_slugs is provided, look up the project IDs
if (project_slugs && project_slugs.length > 0 && projects) {
const projectIds = project_slugs
.map((slug: string) => projects.find(p => p.slug === slug)?.id)
.filter((id: string | undefined) => id !== undefined);
if (projectIds.length > 0) {
queryParams.project = projectIds;
}
}
queryParams.dataset = 'errors';
queryParams.queryDataset = 'error-events';

const {y_axes} = toolLink.params;
if (y_axes) {
queryParams.yAxis = y_axes;
}

if (sort) {
queryParams.sort = sort;
}

return {
pathname: `/organizations/${orgSlug}/explore/discover/homepage/`,
query: queryParams,
};
}

if (dataset === 'logs') {
const queryParams: Record<string, any> = {
[LOGS_QUERY_KEY]: query || '',
project: null,
};

if (stats_period) {
queryParams.statsPeriod = stats_period;
}

// If project_slugs is provided, look up the project IDs
if (project_slugs && project_slugs.length > 0 && projects) {
const projectIds = project_slugs
.map((slug: string) => projects.find(p => p.slug === slug)?.id)
.filter((id: string | undefined) => id !== undefined);
if (projectIds.length > 0) {
queryParams.project = projectIds;
}
}
queryParams[LOGS_QUERY_KEY] = query || '';
delete queryParams.query;

if (sort) {
queryParams[LOGS_SORT_BYS_KEY] = sort;
delete queryParams.sort;
}

return {
Expand All @@ -504,26 +472,8 @@ export function buildToolLinkUrl(

// Default to spans (traces) search
const {y_axes, group_by, mode} = toolLink.params;

const queryParams: Record<string, any> = {
query: query || '',
project: null,
};

// If project_slugs is provided, look up the project IDs
if (project_slugs && project_slugs.length > 0 && projects) {
const projectIds = project_slugs
.map((slug: string) => projects.find(p => p.slug === slug)?.id)
.filter((id: string | undefined) => id !== undefined);
if (projectIds.length > 0) {
queryParams.project = projectIds;
}
}

const aggregateFields: any[] = [];
if (stats_period) {
queryParams.statsPeriod = stats_period;
}

if (y_axes) {
const axes = Array.isArray(y_axes) ? y_axes : [y_axes];
const stringifiedAxes = axes.map(axis => JSON.stringify(axis));
Expand All @@ -536,9 +486,6 @@ export function buildToolLinkUrl(
queryParams.groupBy = groupByValue;
aggregateFields.push(JSON.stringify({groupBy: groupByValue}));
}
if (sort) {
queryParams.sort = sort;
}
if (mode) {
queryParams.mode = mode === 'aggregates' ? 'aggregate' : 'samples';
}
Expand Down
Loading