fix(security): IDOR in PromptsActivityEndpoint GET - scope project by organization#104990
Merged
fix(security): IDOR in PromptsActivityEndpoint GET - scope project by organization#104990
Conversation
… organization The GET endpoint accepted project_id in query params but didn't validate it belonged to the organization, allowing users to potentially query prompt activity data using project IDs from other organizations. Added organization scoping check to the GET method (PUT was already fixed in PR #104920) and a regression test for the GET endpoint.
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Dec 30, 2025
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good to me other than the endpoint parameter consistency.
dcramer
force-pushed
the
fix/idor-prompts-activity-get
branch
from
cc33971 to
3f06a93
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
dcramer
force-pushed
the
fix/idor-prompts-activity-get
branch
from
5fb220b to
3f06a93
Compare
dcramer
force-pushed
the
fix/idor-prompts-activity-get
branch
from
5e62ac4 to
3f06a93
Compare
Member
Author
|
this one is... for some reason, taking a lot of intervention on the agent. def woulda been faster to fix by hand (tho the agent did a great job finding it) |
dcramer
force-pushed
the
fix/idor-prompts-activity-get
branch
from
419f4a6 to
ab78a16
Compare
Member
Author
Follow-up neededThe
This is harmless but redundant. We should follow up to remove |
- Add organization parameter to method signatures for consistency - Remove redundant organization_id query param from GET (use URL org) - Fix fail-open pattern by removing conditional organization check - Add empty string validation for project_id - Update tests to reflect new behavior
dcramer
force-pushed
the
fix/idor-prompts-activity-get
branch
from
ab78a16 to
2b88bec
Compare
Member
Author
Additional follow-up: Split test classesThe test file
This matches the pattern used elsewhere (e.g., |
dcramer
added a commit
that referenced
this pull request
Jan 15, 2026
The GET endpoint now uses the organization from the URL path, making the organization_id query parameter redundant. Also adds explicit error handling when organization is null in promptsCheck(). Follow-up to #104990.
dcramer
added a commit
that referenced
this pull request
Jan 15, 2026
Splits the single test class into GetPromptsActivityTest and PutPromptsActivityTest with a shared base class, matching the pattern used elsewhere (e.g., test_organization_search_details.py). Follow-up to #104990.
jasonyuezhang
pushed a commit
to jasonyuezhang/sentry
that referenced
this pull request
Jan 15, 2026
Splits the single test class into GetPromptsActivityTest and PutPromptsActivityTest with a shared base class, matching the pattern used elsewhere (e.g., test_organization_search_details.py). Follow-up to getsentry#104990.
dcramer
added a commit
that referenced
this pull request
Jan 16, 2026
…106414) Splits the single `PromptsActivityTest` class into separate test classes per HTTP method, following the pattern used elsewhere (e.g., `test_organization_search_details.py`). Structure: - `PromptsActivityTestBase` - shared setUp logic - `GetPromptsActivityTest` - GET endpoint tests (2 tests) - `PutPromptsActivityTest` - PUT endpoint tests (13 tests) This addresses pre-existing technical debt, not introduced by the original PR. Follow-up to #104990.
BYK
pushed a commit
that referenced
this pull request
Jan 19, 2026
…106414) Splits the single `PromptsActivityTest` class into separate test classes per HTTP method, following the pattern used elsewhere (e.g., `test_organization_search_details.py`). Structure: - `PromptsActivityTestBase` - shared setUp logic - `GetPromptsActivityTest` - GET endpoint tests (2 tests) - `PutPromptsActivityTest` - PUT endpoint tests (13 tests) This addresses pre-existing technical debt, not introduced by the original PR. Follow-up to #104990.
jaydgoss
pushed a commit
that referenced
this pull request
Jan 21, 2026
The GET endpoint now uses the organization from the URL path, making the organization_id query parameter redundant. Also adds explicit error handling when organization is null in promptsCheck(). Follow-up to #104990.
jaydgoss
added a commit
that referenced
this pull request
Jan 21, 2026
…106413) Removes the redundant `organization_id` query parameter from the frontend prompts API calls. The GET endpoint now uses the organization from the URL path (after the fix in #104990), making this parameter ignored but harmless. Changes: - Remove `organization_id` from `promptsCheck()`, `makePromptsCheckQueryKey()`, and `batchedPromptsCheck()` - Add explicit error handling in `promptsCheck()` when organization is null (previously would create an invalid URL `/organizations/undefined/...`) Follow-up to #104990. --------- Co-authored-by: Jay Goss <jaygoss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes IDOR vulnerability in
PromptsActivityEndpoint.get()whereproject_idquery parameter was not validated against the organization, allowing users to potentially query prompt activity data using project IDs from other organizations.Note: The PUT endpoint was already fixed in PR #104920, but the GET endpoint was missed.
Changes
project_idin the GET methodtest_idor_get_project_from_different_orgTest plan