ref(scraps): remove compactSelect triggerProps

[TkDodo]

and replace them with a dedicated trigger function that renders a <OverlayTrigger.Button>

depends on:

• ref(ui): Add TimeRangeSelectTrigger #105214

closes: https://linear.app/getsentry/issue/DE-668/streamline-compactselect-triggers

Most of the changes were done automatically by a codemod, but I checked them all afterwards.

The biggest change that was migrated wrongly is that passing children: undefined or children: null in triggerProps before led to the default children being rendered, for example:

triggerProps={{
  prefix: t('Geo region'),
  children: value.length === 0 ? t('All') : undefined,
}}

The 1:1 migration would be:

trigger={triggerProps => (
  <OverlayTrigger.Button {...triggerProps} prefix={t('Geo region')}>
    {value.length === 0 ? t('All') : undefined}
  </OverlayTrigger.Button>
)}

But this won’t work because falling back to undefined means nothing gets rendered.
So the new pattern is falling back to triggerProps.children:

trigger={triggerProps => (
  <OverlayTrigger.Button {...triggerProps} prefix={t('Geo region')}>
-    {value.length === 0 ? t('All') : undefined}
+    {value.length === 0 ? t('All') : triggerProps.children}
  </OverlayTrigger.Button>
)}

As triggerProps contains the defaultLabel as children, but the expression inside the body of OverlayTrigger.Button completely overrides that.

this is the commit where I made most of these changes: 33f22a5

To make this future-proof, I’ve disallowed undefined and null on type-level as children for for SelectTrigger

[linear]

DE-668 streamline compactSelect triggers

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #105215   +/-   ##
========================================
  Coverage   80.62%    80.62%           
========================================
  Files        9428      9428           
  Lines      404023    404015    -8     
  Branches    25661     25659    -2     
========================================
- Hits       325724    325718    -6     
+ Misses      77830     77828    -2     
  Partials      469       469           

[scttcper]

consolidating into one style seems great