Skip to content

feat(console): Update request console sdk access modal and button#105612

Merged
alexsohn1126 merged 54 commits intomasterfrom
alexsohn/feat/add-request-console-sdk-access-button-component
Jan 21, 2026
Merged

feat(console): Update request console sdk access modal and button#105612
alexsohn1126 merged 54 commits intomasterfrom
alexsohn/feat/add-request-console-sdk-access-button-component

Conversation

@alexsohn1126
Copy link
Member

@alexsohn1126 alexsohn1126 commented Jan 2, 2026 •
edited
Loading

Previously the console sdk access modal looked like this:

image

This would create a user feedback that will land in a slack channel, and that would need to be manually put into SaC repo.

This PR changes the modal to the following:

When user has no GitHub identity linked to their Sentry account:
image

When user has a GitHub identity linked to their Sentry account:
image

After inviting themselves into a repository:
image

See this video for what it would look like for the user:
https://github.com/user-attachments/assets/4a682e89-452e-446a-817a-8dcf9db6e781

alexsohn1126 and others added 14 commits December 18, 2025 10:10
@alexsohn1126
Add constants and default options
49979b7
@alexsohn1126
add initial files
a1f26a6
@alexsohn1126
Merge branch 'master' into alexsohn/feat/add-console-sdk-invite-const…
a9a6009 
…ants-and-options
@alexsohn1126
Merge branch 'alexsohn/feat/add-console-sdk-invite-constants-and-opti…
017849b 
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
@alexsohn1126
initial commit
acd2c18
@alexsohn1126
Update constants.py
70bb748
@alexsohn1126
changed defaults and added defaults for testing
a68ac5f
@alexsohn1126
Merge branch 'master' into alexsohn/feat/add-console-sdk-invite-const…
6b4a35a 
…ants-and-options
@alexsohn1126
Merge branch 'alexsohn/feat/add-console-sdk-invite-constants-and-opti…
2416b4b 
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
@alexsohn1126
Merge branch 'alexsohn/feat/add-outbox-generation-for-Identity' into …
2a6d7c3 
…alexsohn/feat/add-github-identity-and-provider-factory-for-testing
@alexsohn1126
remove console-sdk-app name option
19e7649
@alexsohn1126
Merge branch 'alexsohn/feat/add-console-sdk-invite-constants-and-opti…
852912d 
…ons' into alexsohn/feat/add-outbox-generation-for-Identity
@alexsohn1126
Merge branch 'alexsohn/feat/add-outbox-generation-for-Identity' into …
99311ef 
…alexsohn/feat/add-github-identity-and-provider-factory-for-testing
@alexsohn1126
change ordering and flags for defaults
f2cd3d6
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 2, 2026
@alexsohn1126 alexsohn1126 changed the title Alexsohn/feat/add request console sdk access button component feat(console): Add request console sdk access button Jan 5, 2026
@alexsohn1126 alexsohn1126 force-pushed the alexsohn/feat/add-request-console-sdk-access-button-component branch from 410a905 to 98bbe7e Compare January 8, 2026 20:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@alexsohn1126 alexsohn1126 changed the base branch from alexsohn/feat/add-github-identity-and-provider-factory-for-testing to alexsohn/chore/create-flags-for-automatic-console-sdk-invites January 8, 2026 21:02
@alexsohn1126 alexsohn1126 removed the Scope: Backend Automatically applied to PRs that change backend components label Jan 8, 2026
@alexsohn1126 alexsohn1126 mentioned this pull request Jan 8, 2026
Merged
@priscilawebdev
Copy link
Member

priscilawebdev commented Jan 9, 2026

@mujacica I personally thought it would make more sense to let the users invite themselves to whatever game console SDKs they have access to.

If you think the main issue is making the user click in the select field before requesting access, I did make a small update after I recorded the video I sent in Slack to have a default value when they are in project creation page.

Here is the updated video of the flow with the default value plugged in (for Xbox):

Screen.Recording.2026-01-07.at.10.55.43.AM.mov
@priscilawebdev Would love your opinion here as well

I like the new update. PR looks good to me! thanks for improving this flow 🚀

alexsohn1126 added a commit that referenced this pull request Jan 9, 2026
@alexsohn1126
chore(flags):add frontend and backend flags for automatic console sdk…
0e331a7 
… invites (#105952)

These are the flags that will be used in these PRs:

#105612 - Add request game
console sdk access request button component
#105614 - Add org settings page
for sdk invites
Base automatically changed from alexsohn/chore/create-flags-for-automatic-console-sdk-invites to master January 9, 2026 17:27
@alexsohn1126 alexsohn1126 requested a review from a team as a code owner January 9, 2026 17:27
@alexsohn1126
Copy link
Member Author

alexsohn1126 commented Jan 9, 2026

sorry hybridcloud peeps, it seems like the commits from the branch that this PR was merging into makes it so it pings yall for this frontend change 🙇

sentry[bot]
sentry bot reviewed Jan 9, 2026
View reviewed changes
sentry[bot]
sentry bot reviewed Jan 12, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 12, 2026
View reviewed changes
@alexsohn1126
ref(gaming): make projectId optional in PrivateGamingSdkAccessModal
7700ee6 
The projectId prop is only used for analytics tracking and not all
contexts have a project (e.g., org-settings page). This makes it
optional and conditionally spreads it in RequestSdkAccessButton.
@alexsohn1126
fix(gaming): invalidate user identities cache when reopening SDK moda…
611430a 
…l after OAuth

When returning from GitHub OAuth flow, the user identities query had
stale cached data due to staleTime: Infinity. This caused the modal to
incorrectly show the "link GitHub" prompt even after successful auth.

Also removes the conditional `enabled` flag from the query and
simplifies the modal header text.
@alexsohn1126
Copy link
Member Author

alexsohn1126 commented Jan 13, 2026

⚠️⚠️⚠️

Waiting on getsentry endpoints to go live before we ever push this!

I think it should be good to go as soon as the APIs go live

@alexsohn1126 alexsohn1126 merged commit 9862f49 into master Jan 21, 2026
53 checks passed
@alexsohn1126 alexsohn1126 deleted the alexsohn/feat/add-request-console-sdk-access-button-component branch January 21, 2026 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@billyvg billyvg billyvg left review comments

@sentry sentry[bot] sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexsohn1126 @billyvg @mujacica @priscilawebdev