Skip to content

theme: remove linkcolor#105655

Merged
JonasBa merged 4 commits intomasterfrom
jb/theme/linkcolor
Jan 7, 2026
Merged

theme: remove linkcolor#105655
JonasBa merged 4 commits intomasterfrom
jb/theme/linkcolor

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Jan 5, 2026

Fix DE-349

@JonasBa JonasBa requested review from a team as code owners January 5, 2026 18:44
@linear
Copy link
Copy Markdown

linear bot commented Jan 5, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 5, 2026
* Link color indicates that something is clickable
*/
linkColor: tokens.interactive.link.accent.rest,
linkHoverColor: tokens.interactive.link.accent.hover,

This comment was marked as outdated.

const ToggleCollapse = styled(Button)`
margin: ${space(0.5)} 0;
color: ${p => p.theme.linkColor};
color: ${p => p.theme.tokens.interactive.link.accent.rest};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general question: what does rest refer to ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't confirm with @Jesse-Box, but I imagine that it's for when the component is not interacted with (the default state)

@JonasBa JonasBa merged commit fe09340 into master Jan 7, 2026
52 checks passed
@JonasBa JonasBa deleted the jb/theme/linkcolor branch January 7, 2026 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants