Skip to content

theme: remove theme.progressBackground and theme.progressBar#105659

Merged
JonasBa merged 3 commits intomasterfrom
jb/theme/de-360
Jan 7, 2026
Merged

theme: remove theme.progressBackground and theme.progressBar#105659
JonasBa merged 3 commits intomasterfrom
jb/theme/de-360

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Jan 5, 2026

Fix DE-360

@JonasBa JonasBa requested review from a team as code owners January 5, 2026 19:26
@linear
Copy link
Copy Markdown

linear bot commented Jan 5, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 5, 2026
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed these are still using theme.colors.*... are there theme.tokens.interactive.* values we can use instead?

@JonasBa
Copy link
Copy Markdown
Member Author

JonasBa commented Jan 5, 2026

Noticed these are still using theme.colors.*... are there theme.tokens.interactive.* values we can use instead?

Not sure. I don't see any blue colors in there. I think we can swap to use colors first, and then do a codemod where we modify based on the css rule value. So something like color: p.theme.bluexxx would use theme.tokens.content.accent, but that's a separate issue. I'd first like to get rid of the top level properties before making use the right colors are used.

@JonasBa JonasBa enabled auto-merge (squash) January 7, 2026 16:42
@JonasBa JonasBa merged commit b0de911 into master Jan 7, 2026
52 checks passed
@JonasBa JonasBa deleted the jb/theme/de-360 branch January 7, 2026 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants