Conversation
- The status field has unique handling in the Errors querybuilder where it becomes the group.status instead. But this means if a user sends an event with status as a tag the two get confused. This updates the tag endpoint so if we see `status` we assume the user doesn't want the group status but rather whatever status they sent us instead
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| # the events dataset has special handling of the column "status" that breaks when users also send | ||
| # the tag "status". So we need to be explicit its a tag in these cases | ||
| elif dataset == Dataset.Events and tag.key == "status": | ||
| tag.key = "tags[status]" |
Contributor
There was a problem hiding this comment.
Flag backend incorrectly renames status to tags syntax
Low Severity
When using the flag backend (useFlagsBackend=1), a flag named status gets incorrectly renamed to tags[status]. The status → group_status confusion described in the PR only affects the tag backend, not flags (which use distinct flags[...] syntax). The rename condition checks dataset == Dataset.Events and tag.key == "status" but doesn't exclude the flag backend case, causing flag keys to be mislabeled with tag syntax.
dashed
pushed a commit
that referenced
this pull request
Jan 26, 2026
- The status field has unique handling in the Errors querybuilder where it becomes the group.status instead. But this means if a user sends an event with status as a tag the two get confused. This updates the tag endpoint so if we see `status` we assume the user doesn't want the group status but rather whatever status they sent us instead - https://github.com/getsentry/sentry/blob/master/src/sentry/search/events/builder/errors.py#L110-L112
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
- The status field has unique handling in the Errors querybuilder where it becomes the group.status instead. But this means if a user sends an event with status as a tag the two get confused. This updates the tag endpoint so if we see `status` we assume the user doesn't want the group status but rather whatever status they sent us instead - https://github.com/getsentry/sentry/blob/master/src/sentry/search/events/builder/errors.py#L110-L112
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
- The status field has unique handling in the Errors querybuilder where it becomes the group.status instead. But this means if a user sends an event with status as a tag the two get confused. This updates the tag endpoint so if we see `status` we assume the user doesn't want the group status but rather whatever status they sent us instead - https://github.com/getsentry/sentry/blob/master/src/sentry/search/events/builder/errors.py#L110-L112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statuswe assume the user doesn't want the group status but rather whatever status they sent us instead