fix(preprod): hide missing git metadata while uploading

[cameroncooke]

Hide the “Missing Git metadata” build details while an artifact is still uploading/processing.

We currently hide the app info block, showing build metadata is missing while not showing the app info looks strange, this PR address that by hiding all sidebar blocks when app is being processed regardless to whether we have data to show individual blocks.

Refs EME-691

[linear]

EME-691 When uploading, hide missing git data

[cameroncooke]

• fix(preprod): hide missing git metadata while uploading #106103 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sentry]

Bug: The change hides VCS metadata for builds with a FAILED status, removing valuable debugging context, as this data is available at upload time, not post-processing.
_{Severity: HIGH}

🔍 Detailed Analysis

The code change hides the entire build metadata sidebar, including VCS information, when a build's status is FAILED. The underlying assumption is that VCS data is only available after a build is PROCESSED. However, backend analysis shows that VCS metadata is provided during the initial upload and is available even if the build subsequently fails processing. Since FAILED is a terminal state, hiding this information permanently removes critical debugging context like commit SHA, branch, and PR number, which are essential for diagnosing the failure. The test changes in the PR confirm this new, undesirable behavior.

💡 Suggested Fix

Modify the condition to show the BuildVcsInfo component for builds in a FAILED state, in addition to PROCESSED. The sidebar should only be hidden for transient states like UPLOADING or PROCESSING where metadata might genuinely be unavailable. The logic should not treat FAILED as a transient state.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarContent.tsx#L27-L30

Potential issue: The code change hides the entire build metadata sidebar, including VCS
information, when a build's status is `FAILED`. The underlying assumption is that VCS
data is only available after a build is `PROCESSED`. However, backend analysis shows
that VCS metadata is provided during the initial upload and is available even if the
build subsequently fails processing. Since `FAILED` is a terminal state, hiding this
information permanently removes critical debugging context like commit SHA, branch, and
PR number, which are essential for diagnosing the failure. The test changes in the PR
confirm this new, undesirable behavior.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8499253}

[cameroncooke]

Good point, but this is in-fact the requirement.