fix(uptime): Fix skip backfill logic to only run after the interval has been changed #106135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as been changed Currently, the skip backfill logic is causing us to not write misses a lot of the time. I'm updating this logic so that we: - Store a timestamp after we update the interval - If the last_update_ms timestamp occurred before the update, then skip the backfill, since we can assume that any misses there are caused by the change in interval.
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+199
to
+206
| assert timestamp_ms is not None | ||
| assert int(timestamp_ms) > 0 | ||
|
|
||
| now_ms = int(datetime.now(timezone.utc).timestamp() * 1000) | ||
| assert abs(now_ms - int(timestamp_ms)) < 60000 # Within 60 seconds | ||
|
|
||
| def test_no_interval_change_no_redis_timestamp(self) -> None: | ||
| """Verify that updating without changing interval does not set Redis timestamp.""" |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
klochek
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the skip backfill logic is causing us to not write misses a lot of the time. I'm updating this logic so that we: