chore(preprod): Add artifact download panel to admin page#106206
chore(preprod): Add artifact download panel to admin page#106206NicoHinderling merged 3 commits intomasterfrom
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
|
||
| if file_size is None or file_size < 0: | ||
| return Response({"error": "File size unavailable"}, status=500) | ||
| return Response({"detail": "File size unavailable"}, status=500) |
There was a problem hiding this comment.
This is a django best practice apparently. Yes I'm making a web and backend change in one PR but hitting this error case is pretty rare so I don't think its a big deal to separate this into some 3 part PR migration
There was a problem hiding this comment.
i made sure all the frontend handling isnt affected by this btw
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
2 participants
Add the ability to download customers' builds if needed from the _admin preprod page
It's hard to test _admin page changes locally so I may iterate and do a follow up PR if anything is slightly off