ref(checkout): Rework CheckoutOption #106220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| direction="column" | ||
| gap="lg" | ||
| data-test-id="product-option-description" | ||
| > |
Contributor
There was a problem hiding this comment.
SEER description missing paddingTop after refactoring
Low Severity
The SEER product's optionDescription is missing paddingTop="xl" that was present in the old code. The original code had paddingTop="xl" on the description Flex, but during the refactoring to use the new CheckoutOption API, this padding was accidentally omitted. The LEGACY_SEER option correctly preserved this padding. This will result in inconsistent vertical spacing between the separator and description content for the SEER option compared to LEGACY_SEER.
Member
Author
There was a problem hiding this comment.
this is intentional, it was no longer necessary
dashed
approved these changes
Jan 14, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
dashed
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
CheckoutOptioncomponent by including the radio/checkbox depending on the designatedariaRole(rather than leaving the onus on the author using the component)CheckoutOptioninstances so that the instances are always equal width