-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ref(theme): remove legacy border.* theme tokens
#106223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate all usages of deprecated border tokens to their new format: - border.accent → border.accent.vibrant (or .muted, .moderate variants) - border.danger → border.danger.vibrant (or .muted, .moderate variants) - border.muted → border.secondary - border.promotion → border.promotion.vibrant (or .muted, .moderate variants) - border.success → border.success.vibrant (or .muted, .moderate variants) - border.warning → border.warning.vibrant (or .muted, .moderate variants) Also remove the backwards-compatible proxies from compat.tsx to prevent further usage of the legacy tokens. Fixes DE-735
border.* theme tokens
Remove tests for the deprecated backwards-compatible proxy behavior that was removed from compat.tsx. Update the remaining test to use the new explicit .vibrant property access.
Remove all border-related legacy tokens from compat.tsx, including the deprecated `border.muted` alias. Also simplify theme tests to only test the getColorPalette functionality, removing serialization tests that are no longer relevant after removing the compatibility layer.
The component tokens were already removed from master, so we shouldn't re-add them during the rebase.
JonasBa
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change updates all occurrences of the following deprecated tokens:
border.accent→border.accent.vibrantborder.danger→border.danger.vibrantborder.muted→border.secondaryborder.promotion→border.promotion.vibrantborder.success→border.success.vibrantborder.warning→border.warning.vibrantAfter updating all usages, the backwards-compatible proxies have been removed from
compat.tsxto prevent further usage of the legacy tokens.Test plan
Fixes DE-735