Skip to content

Conversation

@natemoo-re
Copy link
Member

Summary

  • Migrate all usages of deprecated border tokens to their new format
  • Remove backwards-compatible proxies from compat.tsx

This change updates all occurrences of the following deprecated tokens:

  • border.accentborder.accent.vibrant
  • border.dangerborder.danger.vibrant
  • border.mutedborder.secondary
  • border.promotionborder.promotion.vibrant
  • border.successborder.success.vibrant
  • border.warningborder.warning.vibrant

After updating all usages, the backwards-compatible proxies have been removed from compat.tsx to prevent further usage of the legacy tokens.

Test plan

  • Visual QA of affected components
  • Verify no console warnings or errors
  • Check that all border colors render correctly

Fixes DE-735

Migrate all usages of deprecated border tokens to their new format:
- border.accent → border.accent.vibrant (or .muted, .moderate variants)
- border.danger → border.danger.vibrant (or .muted, .moderate variants)
- border.muted → border.secondary
- border.promotion → border.promotion.vibrant (or .muted, .moderate variants)
- border.success → border.success.vibrant (or .muted, .moderate variants)
- border.warning → border.warning.vibrant (or .muted, .moderate variants)

Also remove the backwards-compatible proxies from compat.tsx to prevent
further usage of the legacy tokens.

Fixes DE-735
@natemoo-re natemoo-re requested review from a team as code owners January 13, 2026 21:55
@linear
Copy link

linear bot commented Jan 13, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 13, 2026
@natemoo-re natemoo-re changed the title Remove legacy border.* theme tokens ref(theme): remove legacy border.* theme tokens Jan 13, 2026
Remove tests for the deprecated backwards-compatible proxy behavior
that was removed from compat.tsx. Update the remaining test to use
the new explicit .vibrant property access.
natemoo-re and others added 3 commits January 14, 2026 13:45
Remove all border-related legacy tokens from compat.tsx, including
the deprecated `border.muted` alias. Also simplify theme tests to
only test the getColorPalette functionality, removing serialization
tests that are no longer relevant after removing the compatibility
layer.
The component tokens were already removed from master, so we shouldn't
re-add them during the rebase.
@natemoo-re natemoo-re marked this pull request as ready for review January 14, 2026 18:48
@natemoo-re natemoo-re enabled auto-merge (squash) January 14, 2026 19:08
@natemoo-re natemoo-re merged commit 7d646f7 into master Jan 14, 2026
52 checks passed
@natemoo-re natemoo-re deleted the nm/DE-735 branch January 14, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants