ref(scraps): remove theme.button #106264
Merged
ref(scraps): remove theme.button #106264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
those colors were not used inside the button component, so usages have been inlined
github-actions
bot
added
the
Scope: Frontend
TkDodo
commented
Jan 14, 2026
| font-family: ${p => p.theme.text.family}; | ||
| background-color: ${p => | ||
| p.isHovered ? p.theme.button.default.background : p.theme.tokens.background.primary}; | ||
| background-color: ${p => p.theme.tokens.background.primary}; |
Collaborator
Author
There was a problem hiding this comment.
this is the only weird case because theme.button.default.background is the same as theme.tokens.background.primary so the whole condition could be removed.
however, there is still a &:hover css selector that changes the backgroundColor so 🤷
JonasBa
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those colors were not used inside the button component, so usages have been inlined