-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(sentry-apps): Add region RPC service with get_select_options #106276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leeandher
merged 1 commit into
master
from
leander/sai-region-service-1-get-select-options
Jan 14, 2026
Merged
feat(sentry-apps): Add region RPC service with get_select_options #106276
leeandher
merged 1 commit into
master
from
leander/sai-region-service-1-get-select-options
Jan 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces SentryAppRegionService for region silo operations. First method enables fetching select field options from sentry app webhooks. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jan 14, 2026
markstory
approved these changes
Jan 14, 2026
Member
markstory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The method body lines up with the current contents of the endpoint.
leeandher
added a commit
that referenced
this pull request
Jan 14, 2026
Adds the create_issue_link method which allows control silo endpoints to create issue links for Sentry Apps via RPC. This mirrors the functionality in installation_external_issue_actions.py POST. **Stack:** 1. #106276 - get_select_options 2. **#106277** - create_issue_link ← You are here 3. #106278 - create_external_issue 4. #106279 - delete_external_issue 5. #106281 - get_service_hook_projects 6. #106282 - record_interaction Co-authored-by: Claude <noreply@anthropic.com>
leeandher
added a commit
that referenced
this pull request
Jan 14, 2026
…106278) Adds the create_external_issue method which allows control silo endpoints to create external issues for Sentry Apps via RPC. This mirrors the functionality in installation_external_issues.py POST. **Stack:** 1. #106276 - get_select_options 2. #106277 - create_issue_link 3. **#106278** - create_external_issue ← You are here 4. #106279 - delete_external_issue 5. #106281 - get_service_hook_projects 6. #106282 - record_interaction Co-authored-by: Claude <noreply@anthropic.com>
leeandher
added a commit
that referenced
this pull request
Jan 14, 2026
…106279) Adds the delete_external_issue method which allows control silo endpoints to delete external issues for Sentry Apps via RPC. This mirrors the functionality in installation_external_issue_details.py DELETE. Also adds RpcEmptyResult model for operations that return no data. **Stack:** 1. #106276 - get_select_options 2. #106277 - create_issue_link 3. #106278 - create_external_issue 4. **#106279** - delete_external_issue ← You are here 5. #106281 - get_service_hook_projects 6. #106282 - record_interaction Co-authored-by: Claude <noreply@anthropic.com>
leeandher
added a commit
that referenced
this pull request
Jan 15, 2026
…rvice (#106281) Adds service hook projects methods to the region RPC service which allows control silo endpoints to manage service hook projects: - `get_service_hook_projects` - Returns paginated service hook projects for an installation - `set_service_hook_projects` - Replaces all service hook projects with a new set (matches POST endpoint) - `delete_service_hook_projects` - Deletes all service hook projects for an installation (matches DELETE endpoint) All methods support cursor-based pagination via `cursor` and `limit` parameters. Also adds: - `RpcServiceHookProject` model with `id` and `project_id` fields - `RpcServiceHookProjectsResult` with `service_hook_projects` list and `next_cursor` for pagination **Stack:** 1. #106276 - get_select_options 2. #106277 - create_issue_link 3. #106278 - create_external_issue 4. #106279 - delete_external_issue 5. **#106281** - service_hook_projects (get/set/delete) ← You are here 6. #106282 - record_interaction --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new region RPC service (
sentry_app_region) for Sentry Appoperations that require access to region-specific data.
This PR adds the base service structure and the first method:
get_select_optionswhich allows control silo endpoints to fetch selectoptions from Sentry Apps.
Stack: