refactor(dashboards): Convert GenericWidgetQueries consumers to use hook #106284

DominikB2014 · 2026-01-14T18:47:51Z

Update all consumers of GenericWidgetQueries to use the new useGenericWidgetQueries hook instead of the render props pattern. No need to pass down org, selection, api, etc, now that we are using a hook pattern.

This resolves some tech debt and moves us closer to using useQuery instead of the current approach

Update all consumers of GenericWidgetQueries to use the new useGenericWidgetQueries hook instead of the render props pattern. Changes: - issueWidgetQueries: Use hook directly, maintain MemberListStore logic - spansWidgetQueries: Use hook, preserve confidence information handling - widgetQueries: Extract hook logic into separate component to work with OnDemandControlConsumer - releaseWidgetQueries: Use hook, maintain custom error message logic - traceMetricsWidgetQueries: Use hook with disabled/loading state handling All tests passing.

linear · 2026-01-14T18:47:54Z

BROWSE-240 Convert generic widget queries from function component to hook

Remove the GenericWidgetQueries component wrapper and default export since all consumers have been converted to use the useGenericWidgetQueries hook. Also removed the GenericWidgetQueriesProps type and updated releaseWidgetQueries to use UseGenericWidgetQueriesProps in its custom comparator. All tests passing.

…idgetQueries Remove optional api, organization, selection, and queue props from useGenericWidgetQueries hook. The hook now exclusively uses internal React hooks (useApi, useOrganization, usePageFilters, useWidgetQueryQueue). Updated all consumer components (WidgetQueries, IssueWidgetQueries, SpansWidgetQueries, TraceMetricsWidgetQueries, ReleaseWidgetQueries) to not accept or pass these props. Updated all test files to initialize PageFiltersStore for custom selections and pass organization through render options instead of component props.

…zoom Restore minimal override capability for useGenericWidgetQueries hook to support widget viewer modal zoom functionality. Only the selection prop is needed as an override - api, organization, and queue are removed since they use the same hooks/context internally. The widget viewer modal maintains local modalSelection state that changes when users zoom on charts, requiring it to override the global PageFiltersStore selection. All other props (api, organization, queue) were unnecessary as they would access the same context/hooks. Updated all consumer components (IssueWidgetQueries, ReleaseWidgetQueries, WidgetQueries) to only accept optional selection override.

Fix AddToDashboardModal tests by ensuring selection prop is passed through the entire widget rendering chain: WidgetCard -> WidgetCardChartContainer -> WidgetCardDataLoader -> widget query components. This allows the modal to use different selections based on the selected dashboard's saved filters. Previously, WidgetCardDataLoader had selection in its Props type but used Omit<Props, 'selection'> in the function signature, so it was never actually passed through. Also initialize PageFiltersStore in addToDashboardModal.spec.tsx to provide default selection for widget query hooks. Fixes 2 test failures in addToDashboardModal.spec.tsx.

…raceMetricsWidgetQueries Ensure selection prop is consistently passed through the entire widget rendering chain for all widget types. Previously, SpansWidgetQueries and TraceMetricsWidgetQueries were missing the selection prop, so they always used the global PageFiltersStore value instead of the selection passed from parent components. Now all widget query components (IssueWidgetQueries, ReleaseWidgetQueries, WidgetQueries, SpansWidgetQueries, TraceMetricsWidgetQueries) accept an optional selection prop that can override the hook-based selection. This ensures consistent behavior across all widget types for features like: - Widget viewer modal zoom functionality - Dashboard saved filters in AddToDashboardModal All tests continue to pass.

…es and TraceMetricsWidgetQueries" This reverts commit 85078b9.

static/app/views/dashboards/widgetCard/widgetCardDataLoader.tsx