Skip to content

fix(top-issues): Swap Title and Subtitle in Drawer to match Cluster Card#106333

Merged
yuvmen merged 3 commits intomasterfrom
yuvmen/top-issues-drawer-title-subtitle-swap
Jan 16, 2026
Merged

fix(top-issues): Swap Title and Subtitle in Drawer to match Cluster Card#106333
yuvmen merged 3 commits intomasterfrom
yuvmen/top-issues-drawer-title-subtitle-swap

Conversation

@yuvmen
Copy link
Member

@yuvmen yuvmen commented Jan 14, 2026

The title and subtitle are swapped inside the drawer from the card, as we actually use the "Impact" field as the top title in the Cluster Card, swapped it.

@yuvmen yuvmen requested a review from a team as a code owner January 14, 2026 23:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 14, 2026
@yuvmen yuvmen force-pushed the yuvmen/top-issues-drawer-title-subtitle-swap branch from 5eed45a to 96e70f1 Compare January 14, 2026 23:25
<Text size="sm" variant="muted">
{renderWithInlineCode(cluster.title)}
</Text>
) : null}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cluster ID removed from drawer header area

Low Severity

The [CLUSTER-{cluster.cluster_id}] identifier was removed from the header area during this refactor. The old code always displayed this identifier in the subtitle, and the Cluster Card (in dynamicGrouping.tsx) also shows it inline with the impact title. Since this PR's goal is to make the drawer match the Card, the cluster ID should still appear in the header area. While the ID is visible in breadcrumbs, this change makes the drawer inconsistent with the Card it's supposed to match.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intentional, it is displayed right above and is redundant

@yuvmen yuvmen requested a review from scttcper January 15, 2026 21:33
@yuvmen yuvmen merged commit cf0c32f into master Jan 16, 2026
53 checks passed
@yuvmen yuvmen deleted the yuvmen/top-issues-drawer-title-subtitle-swap branch January 16, 2026 18:13
BYK pushed a commit that referenced this pull request Jan 19, 2026
…ard (#106333)

The title and subtitle are swapped inside the drawer from the card, as
we actually use the "Impact" field as the top title in the Cluster Card,
swapped it.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants