fix(code-review): Use a flag that works in control region#106352
Closed
suejung-sentry wants to merge 1 commit into
Closed
fix(code-review): Use a flag that works in control region#106352suejung-sentry wants to merge 1 commit into
suejung-sentry wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
Contributor
Author
|
we're just going to move forward with what we've got already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old flags (
github.webhook.issue-comment,github.webhook.pr) were booleans that were read from control, but their values were only declared in downstream regions. We incorrectly assumed that setting the flag in downstream regions (e.g. DE/US) was sufficient. But actually control must have its own explicit value, otherwise it falls back to the default (True).However, a boolean isn’t expressive enough for control - i.e., control needs to decide per event, per region whether to forward to Overwatch or send directly to Seer, and that requires multiple values, not on/off.
This PR fixes that by replacing the booleans with event-specific lists of regions
seer.code-review.direct-to-seer-regions.issue-commentseer.code-review.direct-to-seer-regions.pull-requestWe can declare these values in the options automator default.yaml so the same values are written to all regions (control, us, de, s4s2...)
Paired with https://github.com/getsentry/sentry-options-automator/pull/6137