feat(preprod): Switch to new URL format in backend (EME-725) by runningcode · Pull Request #106366 · getsentry/sentry

runningcode · 2026-01-15T14:15:09Z

Summary

Part 2 of 3-part deployment to restructure preprod URLs. This PR updates backend URL generation to use the new format.

Deployment order:

Frontend PR (feat(preprod): Add new URL routes while maintaining backwards compatibility (EME-725) #106354) - Already deployed ✅
This PR (Backend) - Deploy second
Frontend cleanup PR (remove old routes - tracked in EME-735) - Deploy last

Example URLs Generated

Before:

/organizations/sentry/preprod/my-project/artifact-123
/organizations/sentry/preprod/my-project/compare/artifact-123/artifact-456

After:

/organizations/sentry/preprod/size/artifact-123?project=my-project
/organizations/sentry/preprod/size/compare/artifact-123/artifact-456?project=my-project

Why This Approach

Since frontend deployed first with redirects:

Old URLs from emails/status checks already sent → Frontend redirects them
After this PR: New URLs generated → Frontend handles them directly
After cleanup PR: Remove redirects, only new format remains

Dependencies

Requires: PR feat(preprod): Add new URL routes while maintaining backwards compatibility (EME-725) #106354 must be deployed first
Enables: Frontend cleanup PR (EME-735) can deploy after this

linear · 2026-01-15T14:15:12Z

EME-725 Adjust URL routes for size and distribution

src/sentry/preprod/url_utils.py

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

tests/sentry/preprod/vcs/status_checks/size/test_templates.py

chromy

looks good % seems like some delta from Ryan's refactoring which maybe ought not to be here

chromy · 2026-01-20T10:23:04Z

src/sentry/preprod/models.py

+            )
+            .select_related("mobile_app_info")
+            .order_by("app_id", "artifact_type", "date_added")
+        )


Is this part of this change? Or is it something unrelated to do with the mobile_app_info refactoring?

This change isn't needed but was a performance optimization suggested by claude which made sense to me.

select_related is the change here which is to prevent n+1 database queries.
With the select_related, Django uses a SQL Join, otherwise it would make a separate database query to fetch the mobile_app_info.

Example:
Before (N+1 queries):
artifacts = PreprodArtifact.objects.filter(...) # 1 query
for artifact in artifacts:
name = artifact.mobile_app_info.app_name # +1 query per artifact

After (1 query):
artifacts = PreprodArtifact.objects.filter(...).select_related("mobile_app_info") # 1 query with JOIN
for artifact in artifacts:
name = artifact.mobile_app_info.app_name # No additional query - already loaded

Just a follow up here, the only usage of this function (get_sibling_artifacts_for_commit()) is in
src/sentry/preprod/vcs/status_checks/size/tasks.py:139 which then calls format_status_check_messages() which then calls _format_artifact_summary() which then gets mobile_app_info on line 134 for every artifact.

Update backend URL generation to use new format with view type in path and project as query parameter. - Update get_preprod_artifact_url() to generate /preprod/{view_type}/{id}?project={slug} - Update get_preprod_artifact_comparison_url() to generate comparison URLs with new format - Update GitHub status check templates to use new URL format - Update tests to verify new URL format

Status check templates were reading from deprecated PreprodArtifact fields (app_name, build_version, build_number) which are no longer populated for artifacts created after migration 0022. This caused app names to display as "--" and versions as "Unknown" in VCS status checks. Changes: - Update get_sibling_artifacts_for_commit() to preload mobile_app_info - Update _format_version_string() to read from mobile_app_info - Update app_name reading to use mobile_app_info.app_name After migration 0022, all mobile app fields are stored in PreprodArtifactMobileAppInfo and should be read from there instead of the deprecated PreprodArtifact fields.

Updated tests to use self.create_preprod_artifact() and self.create_preprod_artifact_size_metrics() factory methods instead of calling Model.objects.create() directly, following test guidelines. The factory methods automatically create PreprodArtifactMobileAppInfo when mobile app fields are provided, ensuring tests work with the new mobile app info model structure. Also updated test assertions to account for platform labels (Android/iOS) being included in qualifier output.

Fixed URL generation to use the correct API for organization.absolute_url() by passing query parameters separately instead of embedding them in the path. This fixes issues with customer domain URL transformations where the regex patterns in customer_domain_path() could mangle URLs with embedded query strings. Changes: - get_preprod_artifact_url: Split path and query parameters - get_preprod_artifact_comparison_url: Split path and query parameters - _format_failure_summary: Pass query as separate parameter This aligns with how other parts of the codebase use absolute_url() (e.g., Project.get_absolute_url, Group.get_absolute_url).

…ix (EME-725)

…s (EME-725) Revert the change that removed platform prefixes from Watch and Dynamic Feature artifact labels. The format is now back to showing both the platform and artifact type (e.g., "iOS, Watch" instead of just "Watch").

runningcode · 2026-01-21T10:15:20Z

tests/sentry/preprod/vcs/status_checks/size/test_templates.py

        # Should have two rows - main app shows sizes, watch shows processing
        assert "`com.example.app`" in summary
-        assert "-- (Watch)" in summary
+        assert "(Android, Watch)" in summary or "(iOS, Watch)" in summary


This change is due to self.create_preprod_artifact now setting the artifact_type whereas before it wasn't set.

runningcode · 2026-01-21T10:15:31Z

tests/sentry/preprod/vcs/status_checks/size/test_templates.py

        # Should have two rows - main app and watch app
        assert "`com.example.app`" in summary  # Both main and watch show app_id
-        assert "-- (Watch)" in summary  # Watch app label
+        assert ", Watch)" in summary  # Watch app label (with platform prefix)


This change is due to self.create_preprod_artifact now setting the artifact_type whereas before it wasn't set.

runningcode · 2026-01-21T10:15:38Z

tests/sentry/preprod/vcs/status_checks/size/test_templates.py

+            if "`com.example.app`" in line and ", Watch)" not in line:
                main_row_idx = i
-            elif "-- (Watch)" in line:
+            elif ", Watch)" in line:


This change is due to self.create_preprod_artifact now setting the artifact_type whereas before it wasn't set.

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 15, 2026

vercel bot deployed to Preview January 15, 2026 14:17 View deployment

runningcode force-pushed the no/eme-725-backend-update-url-generation branch from fb34ac1 to 6b4e546 Compare January 19, 2026 12:46

vercel bot deployed to Preview January 19, 2026 12:49 View deployment

runningcode force-pushed the no/eme-725-backend-update-url-generation branch from 6b4e546 to d29acae Compare January 19, 2026 15:13

vercel bot deployed to Preview January 19, 2026 15:16 View deployment

runningcode marked this pull request as ready for review January 19, 2026 16:16

runningcode requested a review from a team as a code owner January 19, 2026 16:16

vercel bot deployed to Preview January 19, 2026 16:46 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview January 20, 2026 09:33 View deployment

sentry bot reviewed Jan 20, 2026

View reviewed changes

src/sentry/preprod/url_utils.py Outdated Show resolved Hide resolved

cursor bot reviewed Jan 20, 2026

View reviewed changes

tests/sentry/preprod/vcs/status_checks/size/test_templates.py Show resolved Hide resolved

chromy reviewed Jan 20, 2026

View reviewed changes

vercel bot deployed to Preview January 20, 2026 15:49 View deployment

vercel bot deployed to Preview January 20, 2026 16:20 View deployment

runningcode added 5 commits January 21, 2026 09:26

ref(preprod): Remove 'new URL format' comments (EME-735)

b9abd4d

runningcode force-pushed the no/eme-725-backend-update-url-generation branch from a1417bf to 46c7efb Compare January 21, 2026 08:34

vercel bot deployed to Preview January 21, 2026 08:36 View deployment

runningcode added 2 commits January 21, 2026 10:15

ref(preprod): Keep Watch/Dynamic Feature labels without platform pref…

147d6da

…ix (EME-725)

ref(preprod): Remove debug script

efee100

vercel bot deployed to Preview January 21, 2026 09:19 View deployment

vercel bot deployed to Preview January 21, 2026 09:59 View deployment

runningcode commented Jan 21, 2026

View reviewed changes

runningcode requested a review from chromy January 21, 2026 10:15

chromy approved these changes Jan 21, 2026

View reviewed changes

runningcode merged commit d6725df into master Jan 21, 2026
70 checks passed

runningcode deleted the no/eme-725-backend-update-url-generation branch January 21, 2026 14:08

github-actions bot locked and limited conversation to collaborators Feb 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(preprod): Switch to new URL format in backend (EME-725)#106366

feat(preprod): Switch to new URL format in backend (EME-725)#106366
runningcode merged 8 commits intomasterfrom
no/eme-725-backend-update-url-generation

runningcode commented Jan 15, 2026 •

edited

Loading

Uh oh!

linear bot commented Jan 15, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

chromy left a comment

Uh oh!

chromy Jan 20, 2026

Uh oh!

runningcode Jan 20, 2026

Uh oh!

runningcode Jan 21, 2026

Uh oh!

runningcode Jan 21, 2026

Uh oh!

runningcode Jan 21, 2026

Uh oh!

runningcode Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

runningcode commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Example URLs Generated

Why This Approach

Dependencies

Uh oh!

linear bot commented Jan 15, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chromy left a comment

Choose a reason for hiding this comment

Uh oh!

chromy Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

runningcode Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

runningcode Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

runningcode Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

runningcode Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

runningcode Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

runningcode commented Jan 15, 2026 •

edited

Loading