Skip to content

fix: disallow custom CSS in marked#106368

Merged
oioki merged 1 commit intomasterfrom
fix/marked-no-custom-css
Jan 22, 2026
Merged

fix: disallow custom CSS in marked#106368
oioki merged 1 commit intomasterfrom
fix/marked-no-custom-css

Conversation

@oioki
Copy link
Member

@oioki oioki commented Jan 15, 2026

No description provided.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 15, 2026
Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the use-cases for this seem to be AI outputs, summaries, tips, and autofix suggestions. Also the commenting system, the old on

One that i didn't fully chase down, but seems more sus is static/app/views/preprod/components/installDetailsContent.tsx where it looks like we're dumping release_notes, which i assume would be coming from the application that is instrumented with sentry, but that seems like one of the only spots where text can flow in from outside our interface.

Lets ship this, none of the callsites require inline styles/css.

@oioki oioki merged commit 6c308dc into master Jan 22, 2026
54 checks passed
@oioki oioki deleted the fix/marked-no-custom-css branch January 22, 2026 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants