fix(dashboards): Add All Metrics fails to add on first attempt #106371
+2
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
changed the title
narsaynorath
changed the title
DominikB2014
approved these changes
Jan 15, 2026
narsaynorath
deleted the
nar/fix/dashboards-add-to-dashboard-fails-to-add-on-first-attempt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
navigatecall here was triggering a failed attempt to Add to Dashboard for adding All Metrics. The reason why it does this is because the route components are lazily loaded. When the first view occurs, it lazily loads the component. When the navigate is called, it goes down a different code path which seems to remount the component.Getting rid of the navigate call fixes this issue and
location.stateisn't preserved through navigations so there isn't a need to reset the state.