ref(code_review): Split transform_webhook_to_codegen_request by armenzg · Pull Request #106398 · getsentry/sentry

armenzg · 2026-01-15T20:39:23Z

Currently, transform_webhook_to_codegen_request is executed for both issue_comment and pull_request. This decouples the two event types to help comprehension. I also want all data manipulations to happen in the same location rather than throughout different stages (this currently happens during pre-scheduling task & after task scheduling).

This also fixes this issue:

Prevent orphaned state in Seer by allowing CLOSED events through even for draft PRs

Improvements:

Non-PR comments filtered earlier in the flow, thus, we won't unnecesarily schedule them
Clean separation of concerns with dedicated transform functions for each webhook type
DRAFT_PR removed from error types since it's a filter condition, not an error

src/sentry/seer/code_review/utils.py

src/sentry/seer/code_review/webhooks/pull_request.py

Currently, `transform_webhook_to_codegen_request` is executed as part of the task, however, we want to execute prior to scheduling the task. Splitting this function helps with comprehension and will help each GitHub event have its own data transformation path.

…view/armenzg

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/seer/code_review/utils.py

armenzg · 2026-01-20T13:13:48Z

@sentry review

src/sentry/seer/code_review/webhooks/pull_request.py

armenzg · 2026-01-16T21:02:59Z

src/sentry/seer/code_review/webhooks/pull_request.py

    MISSING_PULL_REQUEST = "github.webhook.pull_request.missing-pull-request"
    MISSING_ACTION = "github.webhook.pull_request.missing-action"
    UNSUPPORTED_ACTION = "github.webhook.pull_request.unsupported-action"
-    DRAFT_PR = "github.webhook.pull_request.draft-pr"


We really don't care to track this since we don't run on drafts.

armenzg · 2026-01-16T21:03:38Z

src/sentry/seer/code_review/webhooks/pull_request.py

-    if pull_request.get("draft") is True:
+    # Skip draft check for CLOSED actions to ensure Seer receives cleanup notifications
+    # even if the PR was converted to draft before closing
+    if action != PullRequestAction.CLOSED and pull_request.get("draft") is True:


We recently added support for closed, however, we need to report to Seer even if it's a draft.

armenzg · 2026-01-16T21:04:14Z

src/sentry/seer/code_review/utils.py

    }


-def _get_trigger_metadata(


Not needed.

armenzg · 2026-01-16T21:06:28Z

tests/sentry/seer/code_review/webhooks/test_issue_comment.py

            self.mock_reaction.assert_not_called()
            self.mock_seer.assert_not_called()
+
+    def test_skips_regular_issue_comments(self) -> None:


The new tests are basically some of the tests of test_utils.py.
These convert them from unit tests to integration tests.

armenzg · 2026-01-16T21:07:41Z

tests/sentry/seer/code_review/webhooks/test_pull_request.py

            assert payload["data"]["config"]["trigger_comment_id"] is None
            assert payload["data"]["config"]["trigger_comment_type"] is None
+
+    def test_pull_request_closed_draft_still_sends_to_seer(self) -> None:


This is the test case missing from yesterday's close pull request support.

armenzg · 2026-01-20T13:15:11Z

src/sentry/seer/code_review/webhooks/issue_comment.py

    comment_body = comment.get("body")

+    issue = event.get("issue", {})
+    if not issue.get("pull_request"):


We have been unnecessarily scheduling tasks for GitHub comments that are not part of a pull request. This will drop the numbered of scheduled tasks.

armenzg · 2026-01-20T13:16:59Z

src/sentry/seer/code_review/billing.py

    except OrganizationContributors.DoesNotExist:
-        metrics.incr(
-            "seer.code_review.error.contributor_not_found",
-            tags={"organization_id": organization_id},


Our metrics module should raise errors about forbidden tags, however, it only shows up in the output. I noticed while running tests.

armenzg · 2026-01-20T13:18:16Z

src/sentry/seer/code_review/utils.py

@@ -171,7 +158,7 @@ def _get_target_commit_sha(
 # XXX: Refactor this function to handle it at the handler level rather than during task execution
 def transform_webhook_to_codegen_request(


Reviewing this section is easier with a split view:

armenzg · 2026-01-20T13:38:33Z

src/sentry/seer/code_review/utils.py

-    trigger_user = event_payload.get("sender", {}).get("login") or event_payload.get(
-        "pull_request", {}
-    ).get("user", {}).get("login")
+    # Prioritize sender (person who triggered the action) over PR author


This comment and code changes make it clearer what we were doing in the original code:

armenzg · 2026-01-21T18:51:32Z

@cursoragent resolve the conflicts

cursor · 2026-01-21T18:51:49Z

Perfect! I've successfully resolved the merge conflicts and pushed the changes. Here's what I did:

Conflict Resolution:

Found a merge conflict in src/sentry/seer/code_review/utils.py
The conflict was in the _build_repo_definition function where master had added integration_id handling
Integrated the integration_id logic from master while maintaining your refactored structure with separate transform_issue_comment_to_codegen_request and transform_pull_request_to_codegen_request functions

Changes Made:

Updated _build_repo_definition to build the repo definition dict first, then conditionally add integration_id if present (used for product metrics dashboarding in pr_closed_step)
Fixed the organization_id reference to use repo.organization_id since organization is not a parameter
Committed and pushed the merge to your branch

The branch is now clean and up to date with master, with all conflicts resolved while preserving your PR's refactored code structure.

- Integrated integration_id handling from master into _build_repo_definition - Maintained refactored structure with separate transform functions Co-authored-by: armenzg <armenzg@sentry.io>

src/sentry/seer/code_review/utils.py

giovanni-guidini · 2026-01-22T09:40:03Z

src/sentry/seer/code_review/utils.py

+
+def _build_repo_definition(repo: Repository, target_commit_sha: str) -> dict[str, Any]:
+    """
+    Build the repository definition for the CodecovTaskRequest.


Is it really called CodecovTaskRequest? We should rename that 😅

I have some renaming happening here:
#106810

Currently, `transform_webhook_to_codegen_request` is executed for both `issue_comment` and `pull_request`. This decouples the two event types to help comprehension. I also want all data manipulations to happen in the same location rather than throughout different stages (this currently happens during pre-scheduling task & after task scheduling). This also fixes this issue: * Prevent orphaned state in Seer by allowing CLOSED events through even for draft PRs Improvements: * Non-PR comments filtered earlier in the flow, thus, we won't unnecesarily schedule them * Clean separation of concerns with dedicated transform functions for each webhook type * DRAFT_PR removed from error types since it's a filter condition, not an error --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

armenzg self-assigned this Jan 15, 2026

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 15, 2026

vercel bot deployed to Preview January 15, 2026 20:41 View deployment

cursor bot reviewed Jan 15, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 15, 2026 20:53 View deployment

cursor bot reviewed Jan 15, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/pull_request.py Show resolved Hide resolved

armenzg added 4 commits January 16, 2026 15:56

Port metadata tests

309ca56

Include sender information

0c265e8

No need to track draft pr

b930edb

armenzg force-pushed the 1_15/split_transformation_function/code_review/armenzg branch from def541b to b930edb Compare January 16, 2026 21:00

vercel bot deployed to Preview January 16, 2026 21:02 View deployment

armenzg added 3 commits January 20, 2026 07:32

Restore tests to original state

57ca2f2

Merge branch 'master' into 1_15/split_transformation_function/code_re…

76b804e

…view/armenzg

Fix remaining issues

b7e5c5e

vercel bot deployed to Preview January 20, 2026 12:53 View deployment

cursor bot reviewed Jan 20, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

Fixed tests

72492c5

vercel bot deployed to Preview January 20, 2026 13:05 View deployment

armenzg added 2 commits January 20, 2026 08:27

Fix typing issue

54602c9

Update code and tests

8a82940

vercel bot deployed to Preview January 20, 2026 13:38 View deployment

armenzg commented Jan 20, 2026

View reviewed changes

armenzg marked this pull request as ready for review January 20, 2026 13:40

armenzg requested a review from a team as a code owner January 20, 2026 13:40

Fix typing issue

ff2de2e

vercel bot deployed to Preview January 20, 2026 13:50 View deployment

cursoragent and others added 2 commits January 21, 2026 18:53

Merge master into branch and resolve conflicts

a5e3538

- Integrated integration_id handling from master into _build_repo_definition - Maintained refactored structure with separate transform functions Co-authored-by: armenzg <armenzg@sentry.io>

🛠️ apply pre-commit fixes

226962e

vercel bot deployed to Preview January 21, 2026 18:57 View deployment

giovanni-guidini reviewed Jan 22, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

giovanni-guidini reviewed Jan 22, 2026

View reviewed changes

giovanni-guidini approved these changes Jan 22, 2026

View reviewed changes

Remove

0ef65e6

vercel bot deployed to Preview January 22, 2026 20:36 View deployment

armenzg merged commit c59bf9b into master Jan 23, 2026
66 checks passed

armenzg deleted the 1_15/split_transformation_function/code_review/armenzg branch January 23, 2026 11:32

github-actions bot locked and limited conversation to collaborators Feb 7, 2026

		@@ -171,7 +158,7 @@ def _get_target_commit_sha(
		# XXX: Refactor this function to handle it at the handler level rather than during task execution
		def transform_webhook_to_codegen_request(

Uh oh!

Conversation

armenzg commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

armenzg commented Jan 20, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armenzg commented Jan 21, 2026

Uh oh!

cursor bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

armenzg commented Jan 15, 2026 •

edited

Loading

cursor bot commented Jan 21, 2026 •

edited

Loading