chore: simplify flag check + kill switch#106399
Merged
shruthilayaj merged 10 commits intomasterfrom Jan 15, 2026
Merged
Conversation
wmak
approved these changes
Jan 15, 2026
Member
wmak
left a comment
There was a problem hiding this comment.
Should add more instrumentation before merging but lgtm
Member
Author
|
taskworker task is instrumented, just wrapping flag check with span to see how long the call takes and if we're hitting the cache under it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batching might not be necessary.
Adding a kill switch in case we need to kill
the job in the loop.