fix(seer): Validate project permissions in trace explorer AI query#106432
Merged
fix(seer): Validate project permissions in trace explorer AI query#106432
Conversation
The endpoint was directly trusting user-supplied project IDs without validation, creating an IDOR vulnerability that could allow users to access trace data from projects they don't have permission to view. Use self.get_projects() to properly validate that the user has access to the requested projects before passing them to the Seer API.
github-actions
bot
added
the
Scope: Backend
The get_projects() method expects project_ids as set[int], but we were passing a list. This caused validation failures because list != set even when they contain the same elements.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Fixed two issues in trace explorer AI query endpoint: 1. Test hang: Mock send_translate_request now returns proper dict instead of MagicMock to prevent JSON serialization hang in tests 2. Empty project_ids bug: Validate raw_project_ids before calling get_projects() to prevent empty list from falling back to all user's projects. The condition `if raw_project_ids else None` was treating empty list as None, bypassing the required parameter validation. Changes: - Move validation earlier in flow to check raw input - Remove conditional that converts empty list to None - Add test for empty project_ids with valid query - Replace team permission test with stronger cross-org access test - Remove debug print statements
JoshFerge
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AIML-1708
Also adds missing tests for the TraceExplorerAIQuery endpoint.