ref(sentry-apps): Convert installation endpoints to use RPC services#106461

Merged

leeandher merged 10 commits intomasterfrom

leander/sai-region-service-8-convert-endpoints

Jan 19, 2026

Member

leeandher commented Jan 16, 2026 •

edited

Loading

Convert 6 sentry app installation endpoints from @region_silo_endpoint to @all_silo_endpoint by replacing direct database queries with RPC service calls.

Depends on: #106526 (must be deployed first)

Endpoints converted:

installation_external_requests.py - uses get_select_options RPC
installation_external_issue_actions.py - uses create_issue_link RPC
installation_external_issues.py - uses create_external_issue RPC
installation_external_issue_details.py - uses delete_external_issue RPC
~~installation_service_hook_projects.py - uses service hook RPCs~~ Deferred for a follow up
sentry_app_interaction.py - uses interaction stats RPCs

Also removes obsolete API gateway proxy code since these endpoints no longer need proxying:

Emptied SENTRY_APP_REGION_URL_NAMES tuple
Removed proxy_sentryappinstallation_request and proxy_sentryapp_request functions
Removed related proxy tests

This enables these endpoints to be called from both control and region silos, which is required for the hybrid cloud migration.

Continues the work from #106424.

leeandher requested review from a team as code owners

January 16, 2026 19:42

github-actions bot added the Scope: Backend label

vercel bot deployed to Preview

January 16, 2026 19:44

View deployment

sentry bot reviewed

View reviewed changes

src/sentry/sentry_apps/api/endpoints/installation_external_requests.py Show resolved Hide resolved

cursor bot reviewed

View reviewed changes

Contributor

cursor bot left a comment

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/sentry_apps/api/endpoints/installation_external_issue_actions.py Outdated Show resolved Hide resolved

src/sentry/sentry_apps/api/endpoints/installation_external_issues.py Outdated Show resolved Hide resolved

src/sentry/sentry_apps/api/endpoints/installation_external_issues.py Outdated Show resolved Hide resolved

vercel bot deployed to Preview

January 16, 2026 21:07

View deployment

sentry bot reviewed

View reviewed changes

src/sentry/sentry_apps/api/endpoints/installation_external_issues.py Outdated Show resolved Hide resolved

cursor bot reviewed

View reviewed changes

Contributor

cursor bot left a comment

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/sentry_apps/api/endpoints/sentry_app_interaction.py Show resolved Hide resolved

vercel bot deployed to Preview

January 16, 2026 21:21

View deployment

sentry bot reviewed

View reviewed changes

src/sentry/sentry_apps/api/endpoints/installation_external_issue_actions.py Show resolved Hide resolved

cursor bot reviewed

View reviewed changes

Contributor

cursor bot left a comment

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/sentry_apps/api/endpoints/installation_external_requests.py Outdated Show resolved Hide resolved

leeandher requested a review from a team as a code owner

January 16, 2026 21:58

vercel bot deployed to Preview

January 16, 2026 22:01

View deployment

cursor bot reviewed

View reviewed changes

Contributor

cursor bot left a comment

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/sentry_apps/api/endpoints/installation_service_hook_projects.py Outdated Show resolved Hide resolved

leeandher mentioned this pull request

fix(sentry-apps): Prevent race condition on service hook sentry app rpc #106526

Merged

leeandher force-pushed the leander/sai-region-service-8-convert-endpoints branch from 66cd336 to 65c3054 Compare

January 19, 2026 17:47

vercel bot deployed to Preview

January 19, 2026 17:50

View deployment

cursor bot reviewed

View reviewed changes

Contributor

cursor bot left a comment

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/sentry_apps/services/region/impl.py Outdated Show resolved Hide resolved

markstory reviewed

View reviewed changes

src/sentry/sentry_apps/api/endpoints/installation_service_hook_projects.py Outdated Show resolved Hide resolved

src/sentry/sentry_apps/api/endpoints/installation_service_hook_projects.py Outdated Show resolved Hide resolved

src/sentry/sentry_apps/api/endpoints/installation_service_hook_projects.py Outdated Show resolved Hide resolved

leeandher marked this pull request as draft

January 19, 2026 19:34

leeandher force-pushed the leander/sai-region-service-8-convert-endpoints branch from 65c3054 to b767ecb Compare

January 19, 2026 19:55

vercel bot deployed to Preview

January 19, 2026 19:58

View deployment

leeandher force-pushed the leander/sai-region-service-8-convert-endpoints branch 2 times, most recently from b481ff5 to 984f807 Compare

January 19, 2026 20:01

leeandher added 5 commits

January 19, 2026 15:03


          ref(sentry-apps): Convert external requests endpoint to use RPC

60b369e

Change from region_silo_endpoint to all_silo_endpoint using the
get_select_options RPC method.


          ref(sentry-apps): Convert external issue actions endpoint to use RPC

3d04df5

Change from region_silo_endpoint to all_silo_endpoint using the
create_issue_link RPC method.


          ref(sentry-apps): Convert external issues endpoint to use RPC

286d48d

Change from region_silo_endpoint to all_silo_endpoint using the
create_external_issue RPC method.


          ref(sentry-apps): Convert external issue details endpoint to use RPC

cfd8ca2

Change from region_silo_endpoint to all_silo_endpoint using the
delete_external_issue RPC method.


          ref(sentry-apps): Convert sentry app interaction endpoint to use RPC

5b6619a

Change from region_silo_endpoint to all_silo_endpoint using the
get_interaction_stats and record_interaction RPC methods.

leeandher and others added 4 commits

January 19, 2026 15:03


          ref(sentry-apps): Convert service hook projects endpoint to use RPC

609dffb

Change from region_silo_endpoint to all_silo_endpoint using the
get_service_hook_projects, set_service_hook_projects, and
delete_service_hook_projects RPC methods.


          fix(sentry-apps): Fix type conversion and parameter cleanup

82d8be6

Ensure group_id is converted to int before passing to RPC calls and
remove unused organization_id parameter from record_interaction.


          ref(apigateway): remove obsolete sentry app proxy code

5869bbd

Remove proxy functions and URL names for sentry app installation
endpoints that were converted to @all_silo_endpoint using RPC.

Co-Authored-By: Claude <noreply@anthropic.com>


          revert: Keep service hook projects endpoint as region_silo_endpoint

f766566

Revert conversion of installation_service_hook_projects.py to use RPC.
This endpoint will be converted in a separate PR after the TOCTOU fix
is deployed.

Co-Authored-By: Claude <noreply@anthropic.com>

leeandher force-pushed the leander/sai-region-service-8-convert-endpoints branch from 984f807 to f766566 Compare

January 19, 2026 20:03

leeandher marked this pull request as ready for review

January 19, 2026 20:04

leeandher requested a review from markstory

January 19, 2026 20:04

vercel bot deployed to Preview

January 19, 2026 20:06

View deployment

markstory approved these changes

View reviewed changes


          fix(sentry-apps): Make RPC models hashable for serialization

ec13ee5

Add __hash__ methods to RpcPlatformExternalIssue and RpcServiceHookProject
so they can be used with the serialize() function which uses objects as
dict keys.

vercel bot deployed to Preview

January 19, 2026 20:15

View deployment

leeandher merged commit f8b9813 into master

66 checks passed

leeandher deleted the leander/sai-region-service-8-convert-endpoints branch

January 19, 2026 20:34

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels